Skip to content

Conversation

@hhhui-L
Copy link
Contributor

@hhhui-L hhhui-L commented May 16, 2024

Add the driver to support Phytium SoC mailbox controller.

hhhui-L added 3 commits May 16, 2024 15:21
This patch documents the DT bindings for Phytium KCS interface.

Signed-off-by: Li Guohui <liguohui2061@phytium.com.cn>
Signed-off-by: Chen Baozi <chenbaozi@phytium.com.cn>
Signed-off-by: Wang Yinfeng <wangyinfeng@phytium.com.cn>
Add the driver to support Phytium SoC mailbox controller.

Signed-off-by: Li Guohui <liguohui2061@phytium.com.cn>
Signed-off-by: Chen Baozi <chenbaozi@phytium.com.cn>
Signed-off-by: Wang Xu <wangxu@phytium.com.cn>
Signed-off-by: Wang Yinfeng <wangyinfeng@phytium.com.cn>
There is no completion irq available with Phytium mailbox
implementation. Use the core common polling machinery if we detect
phytium mailbox.

Signed-off-by: Li Guohui <liguohui2061@phytium.com.cn>
Signed-off-by: Chen Baozi <chenbaozi@phytium.com.cn>
Signed-off-by: Wang Yinfeng <wangyinfeng@phytium.com.cn>
@deepin-ci-robot
Copy link

Hi @hhhui-L. Thanks for your PR.

I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@opsiff opsiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@opsiff opsiff merged commit 4199f98 into deepin-community:linux-6.6.y Jun 19, 2024
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • phytium_mbox_send_data函数中,mlink结构体的使用可能不正确,因为它没有在函数参数中传递。
  • phytium_mbox_startupphytium_mbox_shutdown函数中,对mlink的访问应该使用iomem_readiomem_write来确保正确的内存访问。
  • phytium_mbox_last_tx_done函数中,对mlink的访问应该使用iomem_read来确保正确的内存访问。
  • phytium_mbox_probe函数中,对mbox的访问应该使用devm_kzalloc来确保正确的内存分配。
  • phytium_mbox_remove函数中,对mbox的访问应该使用platform_get_drvdata来确保正确的平台驱动数据访问。
  • phytium_mbox_driver结构体中的of_match_tableacpi_match_table应该使用of_matchacpi_device_id类型来定义。
  • 缺少对phytium_mbox_ops结构体的定义,这可能是一个遗漏。
  • 代码中没有对INTR_STATINTR_SET寄存器的访问进行错误检查,这可能会导致未定义行为。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: opsiff
Once this PR has been reviewed and has the lgtm label, please assign zccrs for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

opsiff pushed a commit to opsiff/UOS-kernel that referenced this pull request Dec 22, 2025
This patch documents the DT bindings for Phytium KCS interface.

Signed-off-by: Li Guohui <liguohui2061@phytium.com.cn>
Signed-off-by: Chen Baozi <chenbaozi@phytium.com.cn>
Signed-off-by: Wang Yinfeng <wangyinfeng@phytium.com.cn>
Link: deepin-community#153
(cherry picked from commit 1c4d225)
Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
opsiff pushed a commit to opsiff/UOS-kernel that referenced this pull request Dec 22, 2025
Add the driver to support Phytium SoC mailbox controller.

Signed-off-by: Li Guohui <liguohui2061@phytium.com.cn>
Signed-off-by: Chen Baozi <chenbaozi@phytium.com.cn>
Signed-off-by: Wang Xu <wangxu@phytium.com.cn>
Signed-off-by: Wang Yinfeng <wangyinfeng@phytium.com.cn>
Link: deepin-community#153
(cherry picked from commit 7566b87)
Signed-off-by: Wentao Guan <guanwentao@uniontech.com>

Conflicts:
	drivers/mailbox/Makefile
opsiff pushed a commit to opsiff/UOS-kernel that referenced this pull request Dec 22, 2025
There is no completion irq available with Phytium mailbox
implementation. Use the core common polling machinery if we detect
phytium mailbox.

Signed-off-by: Li Guohui <liguohui2061@phytium.com.cn>
Signed-off-by: Chen Baozi <chenbaozi@phytium.com.cn>
Signed-off-by: Wang Yinfeng <wangyinfeng@phytium.com.cn>
Link: deepin-community#153
(cherry picked from commit 061a2bd)
Signed-off-by: Wentao Guan <guanwentao@uniontech.com>

Conflicts:
	drivers/firmware/arm_scmi/transports/mailbox.c
opsiff pushed a commit to opsiff/UOS-kernel that referenced this pull request Dec 26, 2025
This patch documents the DT bindings for Phytium KCS interface.

Signed-off-by: Li Guohui <liguohui2061@phytium.com.cn>
Signed-off-by: Chen Baozi <chenbaozi@phytium.com.cn>
Signed-off-by: Wang Yinfeng <wangyinfeng@phytium.com.cn>
Link: deepin-community#153
(cherry picked from commit 1c4d225)
Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
opsiff pushed a commit to opsiff/UOS-kernel that referenced this pull request Dec 26, 2025
Add the driver to support Phytium SoC mailbox controller.

Signed-off-by: Li Guohui <liguohui2061@phytium.com.cn>
Signed-off-by: Chen Baozi <chenbaozi@phytium.com.cn>
Signed-off-by: Wang Xu <wangxu@phytium.com.cn>
Signed-off-by: Wang Yinfeng <wangyinfeng@phytium.com.cn>
Link: deepin-community#153
(cherry picked from commit 7566b87)
Signed-off-by: Wentao Guan <guanwentao@uniontech.com>

Conflicts:
	drivers/mailbox/Makefile
opsiff pushed a commit to opsiff/UOS-kernel that referenced this pull request Dec 26, 2025
There is no completion irq available with Phytium mailbox
implementation. Use the core common polling machinery if we detect
phytium mailbox.

Signed-off-by: Li Guohui <liguohui2061@phytium.com.cn>
Signed-off-by: Chen Baozi <chenbaozi@phytium.com.cn>
Signed-off-by: Wang Yinfeng <wangyinfeng@phytium.com.cn>
Link: deepin-community#153
(cherry picked from commit 061a2bd)
Signed-off-by: Wentao Guan <guanwentao@uniontech.com>

Conflicts:
	drivers/firmware/arm_scmi/transports/mailbox.c
lanlanxiyiji pushed a commit that referenced this pull request Dec 26, 2025
This patch documents the DT bindings for Phytium KCS interface.

Signed-off-by: Li Guohui <liguohui2061@phytium.com.cn>
Signed-off-by: Chen Baozi <chenbaozi@phytium.com.cn>
Signed-off-by: Wang Yinfeng <wangyinfeng@phytium.com.cn>
Link: #153
(cherry picked from commit 1c4d225)
Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
lanlanxiyiji pushed a commit that referenced this pull request Dec 26, 2025
Add the driver to support Phytium SoC mailbox controller.

Signed-off-by: Li Guohui <liguohui2061@phytium.com.cn>
Signed-off-by: Chen Baozi <chenbaozi@phytium.com.cn>
Signed-off-by: Wang Xu <wangxu@phytium.com.cn>
Signed-off-by: Wang Yinfeng <wangyinfeng@phytium.com.cn>
Link: #153
(cherry picked from commit 7566b87)
Signed-off-by: Wentao Guan <guanwentao@uniontech.com>

Conflicts:
	drivers/mailbox/Makefile
lanlanxiyiji pushed a commit that referenced this pull request Dec 26, 2025
There is no completion irq available with Phytium mailbox
implementation. Use the core common polling machinery if we detect
phytium mailbox.

Signed-off-by: Li Guohui <liguohui2061@phytium.com.cn>
Signed-off-by: Chen Baozi <chenbaozi@phytium.com.cn>
Signed-off-by: Wang Yinfeng <wangyinfeng@phytium.com.cn>
Link: #153
(cherry picked from commit 061a2bd)
Signed-off-by: Wentao Guan <guanwentao@uniontech.com>

Conflicts:
	drivers/firmware/arm_scmi/transports/mailbox.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants