i3c: Add Phytium i3c controller support #298

yuanxia0927 · 2024-06-27T01:38:33Z

These patches have added support for the Phytium i3c controller and its related functions, and implemented architecture isolation.

Add "phytium,cdns-i3c-master" to be used for Phytium SoC Family. Signed-off-by: yuanxia <yuanxia2073@phytium.com.cn> Signed-off-by: Chen Baozi <chenbaozi@phytium.com.cn> Signed-off-by: Wang Yinfeng <wangyinfeng@phytium.com.cn>

When reading the slave registers, two consecutive slave returns bytes larger than the set PL len will trigger halt on the host, so halt_en is disabled by default for phytium Soc. Signed-off-by: yuanxia <yuanxia2073@phytium.com.cn> Signed-off-by: Song Wenting <songwenting@phytium.com.cn> Signed-off-by: Wu Jinyong <wujinyong1788@phytium.com.cn> Signed-off-by: Chen Baozi <chenbaozi@phytium.com.cn> Signed-off-by: Wang Yinfeng <wangyinfeng@phytium.com.cn>

This patch adds GETMXDS format 1 retransmission to fix GETMXDS format 2 command failure. Signed-off-by: yuanxia <yuanxia2073@phytium.com.cn> Signed-off-by: Song Wenting <songwenting@phytium.com.cn> Signed-off-by: Wu Jinyong <wujinyong1788@phytium.com.cn> Signed-off-by: Chen Baozi <chenbaozi@phytium.com.cn> Signed-off-by: Wang Yinfeng <wangyinfeng@phytium.com.cn>

This patch keeps the CTRL.hj_ack bit disabled until i3c_master_register() is completed in order to prevent slaves from indirect DAA, which causes the driver to fail DAA. Signed-off-by: yuanxia <yuanxia2073@phytium.com.cn> Signed-off-by: Song Wenting <songwenting@phytium.com.cn> Signed-off-by: Wu Jinyong <wujinyong1788@phytium.com.cn> Signed-off-by: Chen Baozi <chenbaozi@phytium.com.cn> Signed-off-by: Wang Yinfeng <wangyinfeng@phytium.com.cn>

This patch documents the DT binding for the Phytium I3C controller. Signed-off-by: yuanxia <yuanxia2073@phytium.com.cn> Signed-off-by: Wu Jinyong <wujinyong1788@phytium.com.cn> Signed-off-by: Wang Yinfeng <wangyinfeng@phytium.com.cn>

This patch provides support for Phytium i3c master controller. Signed-off-by: yuanxia <yuanxia2073@phytium.com.cn> Signed-off-by: Wu Jinyong <wujinyong1788@phytium.com.cn> Signed-off-by: Wang Yinfeng <wangyinfeng@phytium.com.cn>

This patch used to support i3c driver in ACPI mode, this modification is in accordance with standard specifications of MIPI and add special keys to support for PHYTIUM platform. Signed-off-by: yuanxia <yuanxia2073@phytium.com.cn> Signed-off-by: Wu Jinyong <wujinyong1788@phytium.com.cn> Signed-off-by: Wang yinfeng <wangyinfeng@phytium.com.cn>

This patch adds support for S3/S4 mode.When resume from S4 state,the reg value will be overwrite to solve read problems. Signed-off-by: yuanxia <yuanxia2073@phytium.com.cn> Signed-off-by: Wu Jinyong <wujinyong1788@phytium.com.cn> Signed-off-by: Wang Yinfeng <wangyinfeng@phytium.com.cn>

Avenger-285714 · 2024-07-02T08:11:40Z

drivers/i3c/i3c_master_acpi.c

+					if (!strcmp(acpi_elements[0].string.pointer, method)) {
+						*value = acpi_elements[1].integer.value;
+						ret = 0;
+						break;


need to improve code logic

…orms. This patch uses the marco definition of CONFIG_ARCH_PHYTIUM to restrict the use of certain code segments on the phytium platforms, and does not compile this code for other platform. Signed-off-by: yuanxia <yuanxia2073@phytium.com.cn> Signed-off-by: Wu Jinyong <wujinyong1788@phytium.com.cn>

Add "phytium,cdns-i3c-master" to be used for Phytium SoC Family. Signed-off-by: yuanxia <yuanxia2073@phytium.com.cn> Signed-off-by: Chen Baozi <chenbaozi@phytium.com.cn> Signed-off-by: Wang Yinfeng <wangyinfeng@phytium.com.cn> Link: deepin-community#298 (cherry picked from commit 80f143d) Signed-off-by: Wentao Guan <guanwentao@uniontech.com> Conflicts: Documentation/devicetree/bindings/i3c/cdns,i3c-master.yaml

When reading the slave registers, two consecutive slave returns bytes larger than the set PL len will trigger halt on the host, so halt_en is disabled by default for phytium Soc. Signed-off-by: yuanxia <yuanxia2073@phytium.com.cn> Signed-off-by: Song Wenting <songwenting@phytium.com.cn> Signed-off-by: Wu Jinyong <wujinyong1788@phytium.com.cn> Signed-off-by: Chen Baozi <chenbaozi@phytium.com.cn> Signed-off-by: Wang Yinfeng <wangyinfeng@phytium.com.cn> Link: deepin-community#298 (cherry picked from commit a355204) Signed-off-by: Wentao Guan <guanwentao@uniontech.com>

This patch adds GETMXDS format 1 retransmission to fix GETMXDS format 2 command failure. Signed-off-by: yuanxia <yuanxia2073@phytium.com.cn> Signed-off-by: Song Wenting <songwenting@phytium.com.cn> Signed-off-by: Wu Jinyong <wujinyong1788@phytium.com.cn> Signed-off-by: Chen Baozi <chenbaozi@phytium.com.cn> Signed-off-by: Wang Yinfeng <wangyinfeng@phytium.com.cn> Link: deepin-community#298 (cherry picked from commit e5b9750) Signed-off-by: Wentao Guan <guanwentao@uniontech.com>

This patch keeps the CTRL.hj_ack bit disabled until i3c_master_register() is completed in order to prevent slaves from indirect DAA, which causes the driver to fail DAA. Signed-off-by: yuanxia <yuanxia2073@phytium.com.cn> Signed-off-by: Song Wenting <songwenting@phytium.com.cn> Signed-off-by: Wu Jinyong <wujinyong1788@phytium.com.cn> Signed-off-by: Chen Baozi <chenbaozi@phytium.com.cn> Signed-off-by: Wang Yinfeng <wangyinfeng@phytium.com.cn> Link: deepin-community#298 (cherry picked from commit 3b15ce6) Signed-off-by: Wentao Guan <guanwentao@uniontech.com> Conflicts: drivers/i3c/master/i3c-master-cdns.c

This patch documents the DT binding for the Phytium I3C controller. Signed-off-by: yuanxia <yuanxia2073@phytium.com.cn> Signed-off-by: Wu Jinyong <wujinyong1788@phytium.com.cn> Signed-off-by: Wang Yinfeng <wangyinfeng@phytium.com.cn> Link: deepin-community#298 (cherry picked from commit 4fa47c3) Signed-off-by: Wentao Guan <guanwentao@uniontech.com>

This patch provides support for Phytium i3c master controller. Signed-off-by: yuanxia <yuanxia2073@phytium.com.cn> Signed-off-by: Wu Jinyong <wujinyong1788@phytium.com.cn> Signed-off-by: Wang Yinfeng <wangyinfeng@phytium.com.cn> Link: deepin-community#298 (cherry picked from commit 0e0f9b5) Signed-off-by: Wentao Guan <guanwentao@uniontech.com> Conflicts: drivers/i3c/master/Kconfig drivers/i3c/master/Makefile

Log: drivers/i3c/master/i3c-master-phytium.c:1548:15: error: incompatible function pointer types initializing 'int (*)(struct i2c_dev_desc *, struct i2c_msg *, int)' with an expression of type 'int (struct i2c_dev_desc *, const struct i2c_msg *, int)' [-Wincompatible-function-pointer-types] 1548 | .i2c_xfers = phytium_i3c_master_i2c_xfers, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/i3c/master/i3c-master-phytium.c:1689:12: error: incompatible function pointer types initializing 'void (*)(struct platform_device *)' with an expression of type 'int (struct platform_device *)' [-Wincompatible-function-pointer-types] 1689 | .remove = phytium_i3c_master_remove, | ^~~~~~~~~~~~~~~~~~~~~~~~~ Link: deepin-community#298 Signed-off-by: Wentao Guan <guanwentao@uniontech.com>

This patch used to support i3c driver in ACPI mode, this modification is in accordance with standard specifications of MIPI and add special keys to support for PHYTIUM platform. Signed-off-by: yuanxia <yuanxia2073@phytium.com.cn> Signed-off-by: Wu Jinyong <wujinyong1788@phytium.com.cn> Signed-off-by: Wang yinfeng <wangyinfeng@phytium.com.cn> Link: deepin-community#298 (cherry picked from commit 1cf7076) Signed-off-by: Wentao Guan <guanwentao@uniontech.com> Conflicts: drivers/i3c/master.c

Log: drivers/i3c/master/i3c-master-phytium.c:1649:35: error: use of undeclared identifier 'I3C_BUS_MAX_I3C_SCL_RATE' 1649 | master->base.bus.scl_rate.i3c = I3C_BUS_MAX_I3C_SCL_RATE; | ^ 1 error generated. Link: deepin-community#298 Signed-off-by: Wentao Guan <guanwentao@uniontech.com>

This patch adds support for S3/S4 mode.When resume from S4 state,the reg value will be overwrite to solve read problems. Signed-off-by: yuanxia <yuanxia2073@phytium.com.cn> Signed-off-by: Wu Jinyong <wujinyong1788@phytium.com.cn> Signed-off-by: Wang Yinfeng <wangyinfeng@phytium.com.cn> Link: deepin-community#298 (cherry picked from commit d067eb8) Signed-off-by: Wentao Guan <guanwentao@uniontech.com>

…orms. This patch uses the marco definition of CONFIG_ARCH_PHYTIUM to restrict the use of certain code segments on the phytium platforms, and does not compile this code for other platform. Signed-off-by: yuanxia <yuanxia2073@phytium.com.cn> Signed-off-by: Wu Jinyong <wujinyong1788@phytium.com.cn> Link: deepin-community#298 (cherry picked from commit 1371a68) [ Format fix ] Signed-off-by: Wentao Guan <guanwentao@uniontech.com>