Skip to content

Conversation

@Avenger-285714
Copy link
Member

Since this is not a particularly thorough test, if we find any bad bits of RAM then there is a fair chance that there are other bad bits we fail to detect.

Link: https://salsa.debian.org/kernel-team/linux/-/blob/debian/latest/debian/patches/features/x86/x86-memtest-WARN-if-bad-RAM-found.patch?ref_type=heads

Since this is not a particularly thorough test, if we find any bad
bits of RAM then there is a fair chance that there are other bad bits
we fail to detect.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • reserve_bad_mem函数中添加了#ifdef CONFIG_X86条件编译,确保只在x86架构下执行警告信息。
  • 使用WARN_ONCE宏来打印一次警告信息,这有助于避免重复的警告。

是否建议立即修改:

  • 否,当前提交的代码没有明显的语法或逻辑错误。
  • 是,建议添加一些注释来解释为什么在x86架构下需要特别处理,以及WARN_ONCE宏的使用目的。
  • 是,如果WARN_ONCE宏的参数是硬编码的1,建议将其替换为一个更具描述性的错误码或消息,以便于调试和问题追踪。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from avenger-285714. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Avenger-285714 Avenger-285714 merged commit 322291e into deepin-community:linux-6.6.y Dec 27, 2024
4 of 5 checks passed
@opsiff
Copy link
Member

opsiff commented Dec 27, 2024

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants