[Deepin-Kernel-SIG] [Upstream] [linux 6.6-y] Bluetooth: btmtk: Fix failed to send func ctrl for MediaTek devices.

[opsiff]

stable inclusion
from stable-6.12.10
category: bugfix

[ Upstream commit 67dba2c ]

Use usb_autopm_get_interface() and usb_autopm_put_interface() in btmtk_usb_shutdown(), it could send func ctrl after enabling autosuspend.

Bluetooth: btmtk_usb_hci_wmt_sync() hci0: Execution of wmt command
timed out
Bluetooth: btmtk_usb_shutdown() hci0: Failed to send wmt func ctrl
(-110)

Fixes: 5c5e8c5 ("Bluetooth: btmtk: move btusb_mtk_[setup, shutdown] to btmtk.c")
Signed-off-by: Chris Lu chris.lu@mediatek.com
Signed-off-by: Luiz Augusto von Dentz luiz.von.dentz@intel.com
Signed-off-by: Sasha Levin sashal@kernel.org
(cherry picked from commit cd4522b)

Summary by Sourcery

Bug Fixes:

• Resolve issue with MediaTek Bluetooth devices failing to send function control commands during shutdown.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request addresses a bug in the btmtk driver that prevents the device from sending a function control command after autosuspend is enabled. The fix involves using usb_autopm_get_interface() and usb_autopm_put_interface() to ensure the device is properly powered during the shutdown process. Additionally, the pull request replaces sprintf with sysfs_emit in the rfcomm tty driver.

Sequence diagram for btmtk USB device shutdown process

sequenceDiagram
    participant H as HCI Device
    participant D as btmtk Driver
    participant U as USB Interface

    H->>D: btmtk_usb_shutdown()
    D->>U: usb_autopm_get_interface()
    Note over D,U: Ensure device is powered
    D->>H: Send WMT Function Control
    alt Success
        H-->>D: Command Success
        D->>U: usb_autopm_put_interface()
    else Failure
        H-->>D: Command Failed
        D->>U: usb_autopm_put_interface()
        D-->>H: Return Error
    end

Loading

State diagram for USB device power management

stateDiagram-v2
    [*] --> Active: usb_autopm_get_interface()
    Active --> SendingCommand: WMT Function Control
    SendingCommand --> ReleasePower: Command Complete
    ReleasePower --> [*]: usb_autopm_put_interface()
    SendingCommand --> Error: Command Failed
    Error --> ReleasePower

Loading

File-Level Changes

Change	Details	Files
Use usb_autopm_get_interface() and usb_autopm_put_interface() in btmtk_usb_shutdown() to fix the issue of failing to send function control command after enabling autosuspend.	Call usb_autopm_get_interface() before sending the function control command. Call usb_autopm_put_interface() after sending the function control command. Call usb_autopm_put_interface() before returning an error.	drivers/bluetooth/btmtk.c
Replace sprintf with sysfs_emit in rfcomm tty driver.	Replace sprintf with sysfs_emit in address_show function. Replace sprintf with sysfs_emit in channel_show function.	net/bluetooth/rfcomm/tty.c

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @opsiff - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sourcery-ai[bot]
Once this PR has been reviewed and has the lgtm label, please ask for approval from opsiff. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment