-
Notifications
You must be signed in to change notification settings - Fork 105
[Deepin-Kernel-SIG] [Backport] [linux 6.6-y] Sync Uniontech patches from v6.14-rc1 #585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Deepin-Kernel-SIG] [Backport] [linux 6.6-y] Sync Uniontech patches from v6.14-rc1 #585
Conversation
[ Upstream commit f3a3001 ] There is a spelling mistake of 'accesing' in comments which should be 'accessing'. Fixes: 6d76f46 ("ktest: Add useful example configs") Link: https://lore.kernel.org/8714AE3735C0EA0B+20241218140437.194906-1-wangyuli@uniontech.com Reviewed-by: SeongJae Park <sj@kernel.org> Signed-off-by: WangYuli <wangyuli@uniontech.com> Signed-off-by: Steven Rostedt <rostedt@goodmis.org> [ Backport from v6.14-rc1 ] Signed-off-by: WangYuli <wangyuli@uniontech.com>
[ Upstream commit 594c823 ] When inserting a USB device, examining hcd->rsrc_start can be helpful in identifying which hcd is mounted, as the physical address represented here is typically unique. The following code snippet demonstrates this: struct usb_hcd *hcd = bus_to_hcd(udev->bus); unsigned long long usb_hcd_addr = (unsigned long long)hcd->rsrc_start; However, this approach has limitations now. For USB hosts with an MMIO interface, the effectiveness of this method is restricted to USB 2.0. Because commit 3429e91 ("usb: host: xhci: add platform driver support") assigned res->start to hcd->rsrc_start. But shared_hcd->rsrc_start remains unassigned, which is also necessary in certain scenarios. Fixes: 3429e91 ("usb: host: xhci: add platform driver support") Co-developed-by: Xu Rao <raoxu@uniontech.com> Signed-off-by: Xu Rao <raoxu@uniontech.com> Signed-off-by: WangYuli <wangyuli@uniontech.com> Link: https://lore.kernel.org/r/186B9F56972457B4+20250107133854.172309-1-wangyuli@uniontech.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> [ Backport from v6.14-rc1 ] Signed-off-by: WangYuli <wangyuli@uniontech.com>
Reviewer's Guide by SourceryThis pull request backports Uniontech patches from v6.14-rc1 to the linux 6.6-y kernel. The changes include updating the xhci-plat.c file to properly assign resource start and length to the shared HCD, and a minor correction in the ktest defaults.conf file. Sequence diagram for XHCI platform probe resource sharingsequenceDiagram
participant xhci_plat_probe
participant hcd as Host Controller Driver (HCD)
participant shared_hcd as Shared HCD (USB 3.0)
xhci_plat_probe->>hcd: Initialize resources
Note over hcd: Set rsrc_start and rsrc_len
xhci_plat_probe->>shared_hcd: Copy resource values
Note over shared_hcd: New: Set rsrc_start from HCD
Note over shared_hcd: New: Set rsrc_len from HCD
xhci_plat_probe->>shared_hcd: Add shared HCD
Class diagram for USB Host Controller Driver structureclassDiagram
class hcd {
+rsrc_start
+rsrc_len
}
class shared_hcd {
+rsrc_start
+rsrc_len
}
class xhci {
+shared_hcd
}
xhci --> shared_hcd
note for shared_hcd "Now includes resource information from main HCD"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Avenger-285714 - I've reviewed your changes - here's some feedback:
Overall Comments:
- The patch looks good overall. One suggestion: when copying rsrc_start and rsrc_len from hcd to shared_hcd in xhci_plat_probe(), it might be worth adding a brief inline comment explaining why these values are being shared, especially if there are any assumptions about their initialization or consistency. This can help future maintainers understand the rationale behind this resource sharing.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sourcery-ai[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
7c3cfc6
into
deepin-community:linux-6.6.y
Summary by Sourcery
Synchronize Uniontech patches from v6.14-rc1 to Deepin Linux Kernel.
Bug Fixes:
Enhancements:
Tests: