-
Notifications
You must be signed in to change notification settings - Fork 105
deepin: arm64: config: disable some embedded system config #593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deepin: arm64: config: disable some embedded system config #593
Conversation
Reviewer's Guide by SourceryThis pull request disables the ARCH_STM32 configuration in the ARM64 desktop configuration for deepin. The changes remove embedded system settings that are not needed for the desktop environment. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @opsiff - I've reviewed your changes - here's some feedback:
Overall Comments:
- It would be helpful to add a comment explaining why these configurations are not used in the desktop environment.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
WHY? |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sourcery-ai[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Clean the Embedded system config which is not used in desktop. Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
877b392 to
f603fcc
Compare
|
Clean the Embedded system config which is not used in desktop.
Summary by Sourcery
Chores: