[Deepin-Kernel-SIG] [linux 6.6-y] [Hygon] Hygon: Update drivers' support for Hygon model 4h, 6h~8h and 10h processors

[Avenger-285714]

liaoxuan:
Update EDAC, NB, IOMMU, GPIO and KVM drivers for Hygon family 18h model 4h, 6h~8h and 10h processors.

Reference:
https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel/pulls/54
https://gitee.com/anolis/cloud-kernel/pulls/3366

Link: https://gitcode.com/deepin-community/kernel/pull/1

Summary by Sourcery

Update drivers for Hygon family 18h model 4h, 6h-8h, and 10h processors. This includes updates to EDAC, northbridge, IOMMU, GPIO, KVM, and performance monitoring drivers. Additionally, update MCE error descriptions for Hygon Model 7h processors and add support for setting guest PAT to WB to improve performance in non-passthrough scenarios.

Enhancements:

• Update EDAC, NB, IOMMU, GPIO and KVM drivers to support Hygon family 18h model 4h, 6h, 7h, 8h, and 10h processors.
• Add support for setting guest PAT to WB in certain non-passthrough scenarios to improve performance.
• Update MCE error descriptions for Hygon Model 7h processors.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request updates several drivers (EDAC, MCE, KVM, IOMMU, GPIO) to add or improve support for Hygon family 18h model 4h, 6h~8h and 10h processors. The EDAC driver is updated to properly map memory addresses and handle UMC channel enabling. The MCE driver is updated to include Hygon-specific error strings. The KVM driver is updated to allow setting the guest PAT to WB for performance enhancement. The IOMMU driver is updated to recognize the new processor models. The GPIO driver is updated to recognize Hygon GPIO devices.

Sequence diagram for UMC error decoding

sequenceDiagram
    participant CPU
    participant EDAC Driver
    participant UMC

    CPU->>EDAC Driver: Reports MCE (Machine Check Exception)
    EDAC Driver->>EDAC Driver: decode_umc_error(node_id, mce)
    EDAC Driver->>UMC: pvt->ops->get_err_info(m, &err)
    alt hygon_f18h_m4h() && boot_cpu_data.x86_model >= 0x6 || hygon_f18h_m10h()
        EDAC Driver->>EDAC Driver: umc = (err.channel << 1) + ((m->ipid & BIT(13)) >> 13)
    else
        EDAC Driver->>EDAC Driver: umc = err.channel
    end
    EDAC Driver->>UMC: Reads UMC registers to decode error
    UMC-->>EDAC Driver: Error information
    EDAC Driver->>CPU: Logs error information

Loading

Updated class diagram for amd64_pvt struct

classDiagram
    class amd64_pvt {
        -const char *ctl_name
        -int model
        -flags
        +void get_err_info(struct mce *m, struct amd64_error_info *err)
    }
    note for amd64_pvt "This class represents the AMD64 private data, which is updated to include the model number and a pointer to the error info function."

Loading

File-Level Changes

Change	Details	Files
Updated EDAC driver to support Hygon family 18h model 4h, 6h~8h and 10h processors.	Added hygon_f18h_m10h() function to check for Hygon family 18h model 10h processors. Modified umc_normaddr_to_sysaddr() to handle Hygon 18h M4h and M10h processors. Added checks for Hygon 18h M4h and M10h processors when reading DramOffset. Adjusted the number of interleaved dies based on processor model. Modified the die ID shift and mask based on processor model. Added hygon_umc_channel_enabled() to check if a UMC channel is enabled on Hygon M10h processors. Added additional model to the per_family_init function. Adjusted UMC error decoding for Hygon processors. Added checks to skip umc channels that are not enabled.	drivers/edac/amd64_edac.c arch/x86/kernel/amd_nb.c arch/x86/include/asm/amd_nb.h
Added Hygon Model7h Scalable MCA error strings to the MCE driver.	Added smca_ls_mce_hygon_desc and smca_if_mce_hygon_desc arrays for Hygon Model7h error descriptions. Updated mce_amd_init() to use Hygon-specific error descriptions for Hygon processors. Added check for x86_model range 0x7 to 0xf.	drivers/edac/mce_amd.c
Updated KVM driver to allow setting guest PAT to WB for Hygon processors.	Added set_guest_pat_wb module parameter to control guest PAT setting. Added svm_set_guest_pat() function to set guest PAT to WB if enabled and no assigned devices are present. Modified init_vmcb() to call svm_set_guest_pat() during VMCB initialization. Updated svm_set_msr() to handle MSR_IA32_SPEC_CTRL and update guest PAT accordingly. Added GUEST_PAT_WB_ATTR definition.	arch/x86/kvm/svm/svm.c arch/x86/kvm/svm/svm.h
Added Hygon vendor check to the AMD PMU event mapping.	Added a check for X86_VENDOR_HYGON in amd_pmu_event_map() to use the Zen1 event mapping.	arch/x86/events/amd/core.c
Updated IOMMU driver to support Hygon family 18h model 4h and 10h processors.	Added support for Hygon family 18h model 10h processors in check_ioapic_information().	drivers/iommu/amd/init.c
Added ACPI device ID for Hygon GPIO.	Added "HYGO0030" to the amd_gpio_acpi_match table.	drivers/pinctrl/pinctrl-amd.c

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @Avenger-285714 - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟡 Complexity: 1 issue found
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

issue (complexity): Consider creating a helper function to abstract repeated Hygon variant checks.

Consider abstracting the repeated Hygon variant checks into helper functions to simplify the control flow. For example, you can create an inline helper to cover both conditions:

static inline bool is_hygon_variant(void) {
    return hygon_f18h_m4h() || hygon_f18h_m10h();
}

Then replace:

if ((hygon_f18h_m4h() || hygon_f18h_m10h()) && 
    df_indirect_read_instance(nid, 0, 0x214, umc, &ctx.tmp))
    goto out_err;

with:

if (is_hygon_variant() && 
    df_indirect_read_instance(nid, 0, 0x214, umc, &ctx.tmp))
    goto out_err;

Similarly, where you check both positive and negative conditions related to Hygon functions, reuse the helper:

if (!is_hygon_variant())
    intlv_num_sockets = (ctx.tmp >> 8) & 0x1;

This isolates the configuration‐specific logic from the main flow and minimizes duplicated branches while preserving functionality.

[opsiff]

/lgtm

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: opsiff, sourcery-ai[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• deepin/OWNERS [opsiff]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment