[Deepin-Kernel-SIG] [linux 6.6-y] [Backport] wifi: rtw89: pci: disable PCIE wake bit when PCIE deinit

[opsiff]

mainline inclusion
from mainline-v6.14-rc1
category: bugfix

The PCIE wake bit is to control PCIE wake signal to host. When PCIE is going down, clear this bit to prevent waking up host unexpectedly.

Link: https://patch.msgid.link/20241111063835.15454-1-pkshih@realtek.com (cherry picked from commit 9c1df81)

Summary by Sourcery

Bug Fixes:

• Disable the PCIE wake bit when PCIE deinitializes to prevent the host from waking up unexpectedly

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request backports a fix from mainline to disable the PCIE wake bit when PCIE is deinitialized. This prevents the host from being unexpectedly woken up. The changes involve introducing a mac_pre_deinit callback to disable the PCIE wake bit during PCIE deinitialization for AX chips, introducing a power_wake callback to disable the PCIE wake bit during PCIE deinitialization for BE chips, renaming rtw89_pci_power_wake to rtw89_pci_power_wake_ax and updating its usage.

Sequence diagram for PCIE deinitialization

sequenceDiagram
  participant rtw89_dev
  participant rtw89_pci_ops_deinit
  participant rtw89_pci_power_wake

  rtw89_pci_ops_deinit->>rtw89_pci_power_wake: rtw89_pci_power_wake(rtwdev, false)
  rtw89_pci_power_wake-->>rtw89_pci_ops_deinit: return

Loading

Sequence diagram for PCIE pre-deinitialization

sequenceDiagram
  participant rtw89_dev
  participant rtw89_pci_ops_mac_pre_deinit_ax
  participant rtw89_pci_power_wake_ax

  rtw89_pci_ops_mac_pre_deinit_ax->>rtw89_pci_power_wake_ax: rtw89_pci_power_wake_ax(rtwdev, false)
  rtw89_pci_power_wake_ax-->>rtw89_pci_ops_mac_pre_deinit_ax: return

Loading

File-Level Changes

Change	Details	Files
Introduces a mac_pre_deinit callback to disable the PCIE wake bit during PCIE deinitialization for AX chips.	Added rtw89_pci_ops_mac_pre_deinit_ax function to disable the PCIE wake. Assigned rtw89_pci_ops_mac_pre_deinit_ax to the mac_pre_deinit callback in rtw89_pci_gen_ax. Call rtw89_pci_power_wake with false in rtw89_pci_ops_deinit to disable the PCIE wake bit when PCIE is going down.	drivers/net/wireless/realtek/rtw89/pci.c drivers/net/wireless/realtek/rtw89/pci.h
Introduces a power_wake callback to disable the PCIE wake bit during PCIE deinitialization for BE chips.	Added power_wake callback to rtw89_pci_gen_be.	drivers/net/wireless/realtek/rtw89/pci_be.c drivers/net/wireless/realtek/rtw89/pci.h
Renames rtw89_pci_power_wake to rtw89_pci_power_wake_ax and updates its usage.	Renamed rtw89_pci_power_wake to rtw89_pci_power_wake_ax. Updated calls to rtw89_pci_power_wake to rtw89_pci_power_wake_ax in rtw89_pci_ops_mac_pre_init_ax.	drivers/net/wireless/realtek/rtw89/pci.c drivers/net/wireless/realtek/rtw89/pci.h

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @opsiff - I've reviewed your changes - here's some feedback:

Overall Comments:

• It looks like rtw89_pci_power_wake is now a function pointer in rtw89_pci_gen_def, so you should call it through the function pointer instead of directly.
• Consider adding a comment explaining why rtw89_pci_ops_mac_pre_deinit_ax is needed.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sourcery-ai[bot]
Once this PR has been reviewed and has the lgtm label, please ask for approval from opsiff. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment