[Deepin-Kernel-SIG] [Deepin] [linux 6.6-y] deepin: HID: i2c-hid: add a retry loop in i2c_hid_get_report

[opsiff]

A touchscreen cannot work in matebook 14(FLMH model),
failed in i2c_hid_get_report, it return -EAGAIN but retry in i2c-core is failed,
it use i2c-desginware-pcidrv.
usleep(400, 500) not okay, usleep(4000, 5000) is okay

Summary by Sourcery

Implements a retry mechanism in the i2c_hid_get_report function to address touchscreen issues on Matebook 14 devices. The retry loop handles -EAGAIN errors, improving the robustness of the I2C communication.

Bug Fixes:

• Fixes an issue where the touchscreen on Matebook 14 (FLMH model) would not work due to failures in i2c_hid_get_report.

Enhancements:

• Adds a retry loop to i2c_hid_get_report to handle -EAGAIN errors, which occur when the device is temporarily unavailable. The loop retries up to 5 times with a delay of 4000-5000 microseconds between attempts.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request addresses an issue where a touchscreen fails to work on the Matebook 14 (FLMH model) due to the i2c_hid_get_report function returning -EAGAIN. The changes implement a retry loop with a delay to handle the -EAGAIN error, improving the reliability of the I2C communication.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Implemented a retry loop in i2c_hid_get_report to handle -EAGAIN errors.	Added a loop that attempts the i2c_hid_xfer function up to 5 times. Introduced a check within the loop to break if i2c_hid_xfer succeeds. Added a condition to only retry if the error returned by i2c_hid_xfer is -EAGAIN. Included a usleep_range call with a delay of 4000-5000 microseconds when -EAGAIN is encountered.	drivers/hid/i2c-hid/i2c-hid-core.c

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @opsiff - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider adding a comment explaining why a fixed number of retries (5) was chosen.
• It might be good to add a condition to avoid retrying if recv_len is zero.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sourcery-ai[bot]
Once this PR has been reviewed and has the lgtm label, please ask for approval from opsiff. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment