-
Notifications
You must be signed in to change notification settings - Fork 105
[Deepin-Kernel-SIG] [linux 6.6-y] [Deepin] CI: clang build kernel test in x86 and arm64 #627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Deepin-Kernel-SIG] [linux 6.6-y] [Deepin] CI: clang build kernel test in x86 and arm64 #627
Conversation
Reviewer's Guide by SourceryThis pull request adds a new CI job to build the kernel with clang for both x86-64 and arm64 architectures. This change aims to ensure kernel compatibility and stability across different architectures when compiled with clang. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @opsiff - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a step to check for build errors, failing the CI if any are found.
- It might be helpful to cache the build outputs to speed up subsequent CI runs.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
291bb0d to
71e1b4a
Compare
|
Different Linux distributions default to varying Clang versions, although they usually offer a selection of Clang versions in their repositories. It is therefore recommended that you specify CC=clang-19 to take advantage of the latest Clang available on the Deepin distribution. Otherwise, the default Clang version is 17. Incidentally, the LoongArch CI was taken offline previously due to unforeseen circumstances, and I will reinstate it as quickly as I can. |
OK, but in release repo, the llvm and clang version is max 18, I will update LLVM=1 to LLVM=18. |
Use LLVM=18 build kernel to cover compile test. Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
71e1b4a to
f51bf60
Compare
deepin pr auto review代码审查意见如下:
综上所述,建议对代码进行如下修改: - name: 'Clang build kernel'
run: |
# .config
make LLVM=18 deepin_arm64_desktop_defconfig
make LLVM=18 -j$(nproc)修改后的代码: - name: 'Clang build kernel'
run: |
# .config
make LLVM=18 deepin_arm64_desktop_defconfig
make LLVM=18 -j $(nproc)并添加适当的错误处理和日志输出。 |
The LoongArch CI is now operational and back in service! You may wish to integrate Clang-18 checks into the LoongArch infrastructure during this deployment! @opsiff |
The machine for LonngArch runs very slow(3A6000) machine, after analyze the problem, will add clang build kernel in CI for the port,OK? |
Okay, let's proceed with this for the time being. While it appears that increasing build capacity is the only real option. |
|
/lgtm |
Would it be beneficial if I were to add a further new 3A6000 solely for Clang compilation verification? @opsiff |
I think the key problem is the online rate of the runner instread of many runner but droping from server everyday. |
This is irrelevant to the current discussion. Runner online availability is inherently unpredictable across all machines. Only by adding more runners will we increase the sheer number of concurrently active runners. |
chore for github CI pipeline
Summary by Sourcery
CI: