Skip to content

[Deepin-Kernel-SIG] [linux 6.6-y] [Deepin] deepin: config: config SPMI and add a CI for this case #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
opsiff merged 2 commits into from
Mar 5, 2025
Merged

[Deepin-Kernel-SIG] [linux 6.6-y] [Deepin] deepin: config: config SPMI and add a CI for this case #630

opsiff merged 2 commits into from
Mar 5, 2025

Conversation

@opsiff
Copy link
Member

@opsiff opsiff commented Feb 26, 2025 •
edited by sourcery-ai bot
Loading

config SPMI and add a test for github CI pipeline

Summary by Sourcery

CI:

  • Add a CI workflow to check for consistency in the deepin_x86_desktop_defconfig file. The workflow generates a new defconfig file and compares it with the original, reporting an error if differences are found.

@opsiff
deepin: config: config SPMI
5122cd1 
config SPMI for to make sure configs are consistant

Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
@opsiff
CI: add check-config.yml
29578f3 
Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
@sourcery-ai
Copy link

sourcery-ai bot commented Feb 26, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request configures SPMI and adds a CI workflow to check for consistency in the deepin_x86_desktop_defconfig file. The CI workflow automates the process of generating a new defconfig file and comparing it against the original to ensure that no unintended changes are introduced.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Enabled SPMI configuration in the kernel defconfig files.
  • Enabled CONFIG_SPMI.
  • Enabled CONFIG_SPMI_I2C.
  • Enabled CONFIG_SPMI_INTEL_PMC.
 arch/loongarch/configs/deepin_loongarch_desktop_defconfig
arch/x86/configs/deepin_x86_desktop_defconfig
Added a CI workflow to check for consistency in the deepin_x86_desktop_defconfig file.
  • Created a new GitHub Actions workflow file.
  • Configured the workflow to run on push and pull requests.
  • Installed build dependencies.
  • Backed up the original defconfig file.
  • Generated a new defconfig file using make ARCH=x86 deepin_x86_desktop_defconfig and make ARCH=x86 savedefconfig.
  • Compared the generated defconfig file with the original.
  • Added an error message if the files are inconsistent, instructing the user to run make savedefconfig.
 .github/workflows/check-config.yml
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link

deepin-ci-robot commented Feb 26, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from opsiff. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sourcery-ai[bot]
sourcery-ai bot reviewed Feb 26, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @opsiff - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The CI workflow should specify a working-directory to avoid potential conflicts with other workflows or actions.
  • Consider adding a step to explicitly set the kernel version being built to avoid unexpected behavior.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Avenger-285714
Copy link
Member

Avenger-285714 commented Mar 3, 2025

/lgtm

@opsiff opsiff merged commit a893b9c into deepin-community:linux-6.6.y Mar 5, 2025
4 of 6 checks passed
@MingcongBai MingcongBai mentioned this pull request Mar 5, 2025
Open
lyt31 pushed a commit to lyt31/kernel that referenced this pull request Apr 27, 2025
@brauner
erofs: reliably distinguish block based and fscache mode
0d16abb 
commit 7af2ae1 upstream.

When erofs_kill_sb() is called in block dev based mode, s_bdev may not
have been initialised yet, and if CONFIG_EROFS_FS_ONDEMAND is enabled,
it will be mistaken for fscache mode, and then attempt to free an anon_dev
that has never been allocated, triggering the following warning:

============================================
ida_free called for id=0 which is not allocated.
WARNING: CPU: 14 PID: 926 at lib/idr.c:525 ida_free+0x134/0x140
Modules linked in:
CPU: 14 PID: 926 Comm: mount Not tainted 6.9.0-rc3-dirty deepin-community#630
RIP: 0010:ida_free+0x134/0x140
Call Trace:
 <TASK>
 erofs_kill_sb+0x81/0x90
 deactivate_locked_super+0x35/0x80
 get_tree_bdev+0x136/0x1e0
 vfs_get_tree+0x2c/0xf0
 do_new_mount+0x190/0x2f0
 [...]
============================================

Now when erofs_kill_sb() is called, erofs_sb_info must have been
initialised, so use sbi->fsid to distinguish between the two modes.

Signed-off-by: Christian Brauner <brauner@kernel.org>
Signed-off-by: Baokun Li <libaokun1@huawei.com>
Reviewed-by: Jingbo Xu <jefflexu@linux.alibaba.com>
Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Link: https://lore.kernel.org/r/20240419123611.947084-3-libaokun1@huawei.com
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@chenchongbiao chenchongbiao Awaiting requested review from chenchongbiao

@justforlxz justforlxz Awaiting requested review from justforlxz

@MingcongBai MingcongBai Awaiting requested review from MingcongBai

@Avenger-285714 Avenger-285714 Awaiting requested review from Avenger-285714

Assignees

@Avenger-285714 Avenger-285714

Labels

lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@opsiff @deepin-ci-robot @Avenger-285714