forked from abacusmodeling/abacus-develop
-
Notifications
You must be signed in to change notification settings - Fork 156
Closed
Labels
Feature DiscussedThe features will be discussed first but will not be implemented soonThe features will be discussed first but will not be implemented soon
Description
Background
The usage of template parameters in ABACUS is relatively confusing. Here are a few examples:
-
complex<FPTYPE>is used uniformly in PW code, that is,FPYTPEcannot takecomplex<double>; -
There is
complex<T>in the DiagoBPCG written by @denghuilu, soThere cannot becomplex<double>too; -
However:
TinHamiltonLCAO<T>can becomplex<double>; -
And In the new
ESolver_LRmodule,FPTYPEcan also becomplex<double>...
Describe the solution you'd like
In the PW calculation, we employ a unified numerical type template represented by 'T' instead of 'FPTYPE' to denote the calculation's numerical type. This 'T' template is designed to accommodate various data types, including 'std::complex' and others.
Additional Context
No response
Task list for Issue attackers
- Review and understand the proposed feature and its importance.
- Research on the existing solutions and relevant research articles/resources.
- Discuss with the team to evaluate the feasibility of implementing the feature.
- Create a design document outlining the proposed solution and implementation details.
- Get feedback from the team on the design document.
- Develop the feature following the agreed design.
- Write unit tests and integration tests for the feature.
- Update the documentation to include the new feature.
- Perform code review and address any issues.
- Merge the feature into the main branch.
- Monitor for any issues or bugs reported by users after the feature is released.
- Address any issues or bugs reported by users and continuously improve the feature.
Reactions are currently unavailable
Metadata
Metadata
Labels
Feature DiscussedThe features will be discussed first but will not be implemented soonThe features will be discussed first but will not be implemented soon