Skip to content

Proper design for init_wfc needed #6875

@Cstandardlib

Description

@Cstandardlib

Describe the Code Quality Issue

Now abacus will quit if init_wfc is set to atomic(default) while no atomic wfcs are read from pseudopotentials, leaving a warning message.

  1. Since the atomic option is the default option it is better to pop a warning but not quit and complete the calculation.
  2. Need to output information like "aaa atomic + bbb random" for all cases.
  3. Update the docs and inform users of atomic->random degeneration on pseupotentials without PP_PSWFC.

Additional Context

No response

Task list for Issue attackers (only for developers)

  • Identify the specific code file or section with the code quality issue.
  • Investigate the issue and determine the root cause.
  • Research best practices and potential solutions for the identified issue.
  • Refactor the code to improve code quality, following the suggested solution.
  • Ensure the refactored code adheres to the project's coding standards.
  • Test the refactored code to ensure it functions as expected.
  • Update any relevant documentation, if necessary.
  • Submit a pull request with the refactored code and a description of the changes made.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Features NeededThe features are indeed needed, and developers should have sophisticated knowledgeInput&OutputSuitable for coders without knowing too many DFT details

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions