Merged
Conversation
* Add the dipole and spectrum post-processing script. (deepmodeling#1928) * Add the Dipole and post-processing script necessary to calculate the spectrum using TDDFT. * fix td_val test bug. * Fix: bug in parsing strings mixed with " ", "\t" (deepmodeling#1951) * Use template to reconstruct parse_expression * Feature: output R matrix at each MD step * Modify'matrix_HS' to 'matrix' for R matrix output * Merge branches 'develop' and 'develop' of https://github.com/1041176461/abacus-develop into develop * Fix: modify index in parse_expression * Fix: bug in parsing strings mixed with " ", "\t" --------- Co-authored-by: jiyuang <jiyuyang@mail.ustc.com> * solve conflicts * solve conflicts * solve conflicts * solve conflicts * solve conflicts * Fix : bug of multi-kpoint for tddft (deepmodeling#2023) * fix bug of electric field in tddft * fix bug of dipole and electric field * fix bug of multi-kpoint for tddft * unit conversion of out_efield * delete useless paramters for tddft (td_val_elec*) * delete useless parameters for tddft * pack all changes in tddft * solve conflicts * delete td_val --------- Co-authored-by: HeFuxiang94 <78629482+HeFuxiang94@users.noreply.github.com> Co-authored-by: jiyuyang <1041176461@qq.com> Co-authored-by: jiyuang <jiyuyang@mail.ustc.com>
* New propagator for better Convergence * Add files via upload * Add files via upload * Modified the code's implementation approach. I have modified the implementation approach of the code, and this one involves less changes to the original code. It also includes handling for multiple k-points. * Delete module_esolver directory * Delete module_hamilt_general directory * Delete module_hamilt_lcao directory * Add files via upload
…eling#2272) * Add the dipole and spectrum post-processing script. (deepmodeling#1928) * Add the Dipole and post-processing script necessary to calculate the spectrum using TDDFT. * fix td_val test bug. * Fix: bug in parsing strings mixed with " ", "\t" (deepmodeling#1951) * Use template to reconstruct parse_expression * Feature: output R matrix at each MD step * Modify'matrix_HS' to 'matrix' for R matrix output * Merge branches 'develop' and 'develop' of https://github.com/1041176461/abacus-develop into develop * Fix: modify index in parse_expression * Fix: bug in parsing strings mixed with " ", "\t" --------- Co-authored-by: jiyuang <jiyuyang@mail.ustc.com> * solve conflicts * solve conflicts * solve conflicts * solve conflicts * solve conflicts * Fix : bug of multi-kpoint for tddft (deepmodeling#2023) * fix bug of electric field in tddft * fix bug of dipole and electric field * fix bug of multi-kpoint for tddft * unit conversion of out_efield * delete useless paramters for tddft (td_val_elec*) * delete useless parameters for tddft * pack all changes in tddft * solve conflicts * delete td_val * simplify matrix multiplication and update new propagator for tddft * add autotests for new propagator * fix bug of ekb in tddft * delete temp output * update ref of new propagator * update CASES --------- Co-authored-by: HeFuxiang94 <78629482+HeFuxiang94@users.noreply.github.com> Co-authored-by: jiyuyang <1041176461@qq.com> Co-authored-by: jiyuang <jiyuyang@mail.ustc.com> Co-authored-by: Qianrui <76200646+Qianruipku@users.noreply.github.com>
dyzheng
reviewed
May 12, 2023
dyzheng
requested changes
May 12, 2023
Collaborator
Author
|
Fix #1935 |
dyzheng
requested changes
May 15, 2023
Collaborator
dyzheng
left a comment
dyzheng
left a comment
There was a problem hiding this comment.
Annotations is almost okay but some unittests is lack.
Collaborator
|
please fix conflicts for this PR |
dyzheng
approved these changes
May 17, 2023
dyzheng
approved these changes
May 17, 2023
…velop into refactor_tddft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.