Test: UnitTest for module_tddft#2580
Merged
dyzheng merged 69 commits intodeepmodeling:developfrom Jun 8, 2023
Merged
Conversation
* Add the dipole and spectrum post-processing script. (deepmodeling#1928) * Add the Dipole and post-processing script necessary to calculate the spectrum using TDDFT. * fix td_val test bug. * Fix: bug in parsing strings mixed with " ", "\t" (deepmodeling#1951) * Use template to reconstruct parse_expression * Feature: output R matrix at each MD step * Modify'matrix_HS' to 'matrix' for R matrix output * Merge branches 'develop' and 'develop' of https://github.com/1041176461/abacus-develop into develop * Fix: modify index in parse_expression * Fix: bug in parsing strings mixed with " ", "\t" --------- Co-authored-by: jiyuang <jiyuyang@mail.ustc.com> * solve conflicts * solve conflicts * solve conflicts * solve conflicts * solve conflicts * Fix : bug of multi-kpoint for tddft (deepmodeling#2023) * fix bug of electric field in tddft * fix bug of dipole and electric field * fix bug of multi-kpoint for tddft * unit conversion of out_efield * delete useless paramters for tddft (td_val_elec*) * delete useless parameters for tddft * pack all changes in tddft * solve conflicts * delete td_val --------- Co-authored-by: HeFuxiang94 <78629482+HeFuxiang94@users.noreply.github.com> Co-authored-by: jiyuyang <1041176461@qq.com> Co-authored-by: jiyuang <jiyuyang@mail.ustc.com>
* New propagator for better Convergence * Add files via upload * Add files via upload * Modified the code's implementation approach. I have modified the implementation approach of the code, and this one involves less changes to the original code. It also includes handling for multiple k-points. * Delete module_esolver directory * Delete module_hamilt_general directory * Delete module_hamilt_lcao directory * Add files via upload
…eling#2272) * Add the dipole and spectrum post-processing script. (deepmodeling#1928) * Add the Dipole and post-processing script necessary to calculate the spectrum using TDDFT. * fix td_val test bug. * Fix: bug in parsing strings mixed with " ", "\t" (deepmodeling#1951) * Use template to reconstruct parse_expression * Feature: output R matrix at each MD step * Modify'matrix_HS' to 'matrix' for R matrix output * Merge branches 'develop' and 'develop' of https://github.com/1041176461/abacus-develop into develop * Fix: modify index in parse_expression * Fix: bug in parsing strings mixed with " ", "\t" --------- Co-authored-by: jiyuang <jiyuyang@mail.ustc.com> * solve conflicts * solve conflicts * solve conflicts * solve conflicts * solve conflicts * Fix : bug of multi-kpoint for tddft (deepmodeling#2023) * fix bug of electric field in tddft * fix bug of dipole and electric field * fix bug of multi-kpoint for tddft * unit conversion of out_efield * delete useless paramters for tddft (td_val_elec*) * delete useless parameters for tddft * pack all changes in tddft * solve conflicts * delete td_val * simplify matrix multiplication and update new propagator for tddft * add autotests for new propagator * fix bug of ekb in tddft * delete temp output * update ref of new propagator * update CASES --------- Co-authored-by: HeFuxiang94 <78629482+HeFuxiang94@users.noreply.github.com> Co-authored-by: jiyuyang <1041176461@qq.com> Co-authored-by: jiyuang <jiyuyang@mail.ustc.com> Co-authored-by: Qianrui <76200646+Qianruipku@users.noreply.github.com>
mohanchen
approved these changes
Jun 7, 2023
hongriTianqi
suggested changes
Jun 7, 2023
There was a problem hiding this comment.
Can you please analyze the reason why case tests take 5 minutes more in this PR? @lyb9812
In addition, multiple case tests deliver warnings with large derivation from the original results. This is unacceptable: 
|
This ISSUE is induced by my own PR #2477. I will take care of this issue. |
hongriTianqi
approved these changes
Jun 7, 2023
Collaborator
Author
The total time of tests change from 34m to 40m since PR#2477. |
Collaborator
Author
The warnings are the same as PR #2604 (the last received PR). So it is not introduced by this PR. It seems start from PR #2527 . |
|
can you please check the two test cases of 601, which are related to TDDFT code. Can you please solve the warnnings in these two case tests? Thanks! @lyb9812 
|
|
The warnings do not start from PR #2527, I am still searching for it .... |
|
This issue is not induced by PR #2477, I am still searching for it ... |
5 more minutes are taken by EXX case tests, which were introduced in PR #2478. @lyb9812 @Qianruipku |
Collaborator
Author
There are no changes related to tddft in PR #2503 . The warnings in these two cases may be due to the random phase of wavefunction. I will confirm it after I complete the function of restart. |
hongriTianqi
approved these changes
Jun 7, 2023
dyzheng
approved these changes
Jun 8, 2023
jinzx10
pushed a commit
to jinzx10/abacus-develop
that referenced
this pull request
Jun 10, 2023
* Merge develop branch to TDDFT branch (deepmodeling#2249) * Add the dipole and spectrum post-processing script. (deepmodeling#1928) * Add the Dipole and post-processing script necessary to calculate the spectrum using TDDFT. * fix td_val test bug. * Fix: bug in parsing strings mixed with " ", "\t" (deepmodeling#1951) * Use template to reconstruct parse_expression * Feature: output R matrix at each MD step * Modify'matrix_HS' to 'matrix' for R matrix output * Merge branches 'develop' and 'develop' of https://github.com/1041176461/abacus-develop into develop * Fix: modify index in parse_expression * Fix: bug in parsing strings mixed with " ", "\t" --------- Co-authored-by: jiyuang <jiyuyang@mail.ustc.com> * solve conflicts * solve conflicts * solve conflicts * solve conflicts * solve conflicts * Fix : bug of multi-kpoint for tddft (deepmodeling#2023) * fix bug of electric field in tddft * fix bug of dipole and electric field * fix bug of multi-kpoint for tddft * unit conversion of out_efield * delete useless paramters for tddft (td_val_elec*) * delete useless parameters for tddft * pack all changes in tddft * solve conflicts * delete td_val --------- Co-authored-by: HeFuxiang94 <78629482+HeFuxiang94@users.noreply.github.com> Co-authored-by: jiyuyang <1041176461@qq.com> Co-authored-by: jiyuang <jiyuyang@mail.ustc.com> * New propagator for better Convergence (deepmodeling#2253) * New propagator for better Convergence * Add files via upload * Add files via upload * Modified the code's implementation approach. I have modified the implementation approach of the code, and this one involves less changes to the original code. It also includes handling for multiple k-points. * Delete module_esolver directory * Delete module_hamilt_general directory * Delete module_hamilt_lcao directory * Add files via upload * Update dipole.py (deepmodeling#2270) * Simplify matrix multiplication and add new propagator method (deepmodeling#2272) * Add the dipole and spectrum post-processing script. (deepmodeling#1928) * Add the Dipole and post-processing script necessary to calculate the spectrum using TDDFT. * fix td_val test bug. * Fix: bug in parsing strings mixed with " ", "\t" (deepmodeling#1951) * Use template to reconstruct parse_expression * Feature: output R matrix at each MD step * Modify'matrix_HS' to 'matrix' for R matrix output * Merge branches 'develop' and 'develop' of https://github.com/1041176461/abacus-develop into develop * Fix: modify index in parse_expression * Fix: bug in parsing strings mixed with " ", "\t" --------- Co-authored-by: jiyuang <jiyuyang@mail.ustc.com> * solve conflicts * solve conflicts * solve conflicts * solve conflicts * solve conflicts * Fix : bug of multi-kpoint for tddft (deepmodeling#2023) * fix bug of electric field in tddft * fix bug of dipole and electric field * fix bug of multi-kpoint for tddft * unit conversion of out_efield * delete useless paramters for tddft (td_val_elec*) * delete useless parameters for tddft * pack all changes in tddft * solve conflicts * delete td_val * simplify matrix multiplication and update new propagator for tddft * add autotests for new propagator * fix bug of ekb in tddft * delete temp output * update ref of new propagator * update CASES --------- Co-authored-by: HeFuxiang94 <78629482+HeFuxiang94@users.noreply.github.com> Co-authored-by: jiyuyang <1041176461@qq.com> Co-authored-by: jiyuang <jiyuyang@mail.ustc.com> Co-authored-by: Qianrui <76200646+Qianruipku@users.noreply.github.com> * delete td_htype and update ref of tddft autotests * delete td_htype * refactor tddft code * move read_paramter of electric field to input_conv.cpp for tddft * sve conflicts * move definition of tag * convert read_parameter * add namespace module_tddft * remove tmp file * move read_paramters of electric field in tddft to input_conv.cpp * add force of tddft efield * add annotations * move read_parameters from H_TDDFT_pw.cpp to input_conv.cpp * add ifdef __LCAO * remove input parameter of read_td_efield * remove input parameter of read_td_efield * fix bug for input UTs * change name of parameters of compute_force in H_TDDFT_pw.h * improve annotation * solve conflicts * solve conflicts * add UT for read_td_efield * add ifdef __LCAO * add ifdef __LCAO * mistake for TEST and TEST_F * fix ReadTdEfieldTest * fix ReadTdEfieldTest * add doublenear() for EXPECT_EQ in ReadEfieldTest * add nampspace for doublenear * add nampspace for doublenear * mistake * replace doublenear with EXPECT_NEAR * TEST_F * delete nband in propagator * add UT for module tddft * comment add_test * fix bug of prepare() in H_TDDFT_pw.cpp * split tddft_test * fix bug * fix bug of UT for tddft * add tddft prefix * add UT for cblacs_gridinit * fix bug of UT for tddft * fix bug of UT for tddft --------- Co-authored-by: HeFuxiang94 <78629482+HeFuxiang94@users.noreply.github.com> Co-authored-by: jiyuyang <1041176461@qq.com> Co-authored-by: jiyuang <jiyuyang@mail.ustc.com> Co-authored-by: HTZhao <104255052+ESROAMER@users.noreply.github.com> Co-authored-by: Omega <62006565+Satinelamp@users.noreply.github.com> Co-authored-by: Qianrui <76200646+Qianruipku@users.noreply.github.com>
mohanchen
pushed a commit
that referenced
this pull request
Jun 10, 2023
…ao (#2610) * remove unnecessary "this" * allow copy of RadialSet & calculate rcut_max on demand * clean up * add "RadialCollection", the top-level container for radial functions * enable MPI test for module_nao & bug fix for reading orbital file * clean up * BetaRadials implemented * Fix: compiling warning by both Intel and GNU compilers (#2609) * Fix: warning detected by intel compiler * Fix: compiling warning detected by GNU compiler * Fix: error --------- Co-authored-by: dyzheng <zhengdy@bjaisi.com> * Fix: optimized printing of start magnetization (#2605) * Fix: optimized printing of start magnetization * Fix: update refs in examples --------- Co-authored-by: dyzheng <zhengdy@bjaisi.com> * Test: UnitTest for module_tddft (#2580) * Merge develop branch to TDDFT branch (#2249) * Add the dipole and spectrum post-processing script. (#1928) * Add the Dipole and post-processing script necessary to calculate the spectrum using TDDFT. * fix td_val test bug. * Fix: bug in parsing strings mixed with " ", "\t" (#1951) * Use template to reconstruct parse_expression * Feature: output R matrix at each MD step * Modify'matrix_HS' to 'matrix' for R matrix output * Merge branches 'develop' and 'develop' of https://github.com/1041176461/abacus-develop into develop * Fix: modify index in parse_expression * Fix: bug in parsing strings mixed with " ", "\t" --------- Co-authored-by: jiyuang <jiyuyang@mail.ustc.com> * solve conflicts * solve conflicts * solve conflicts * solve conflicts * solve conflicts * Fix : bug of multi-kpoint for tddft (#2023) * fix bug of electric field in tddft * fix bug of dipole and electric field * fix bug of multi-kpoint for tddft * unit conversion of out_efield * delete useless paramters for tddft (td_val_elec*) * delete useless parameters for tddft * pack all changes in tddft * solve conflicts * delete td_val --------- Co-authored-by: HeFuxiang94 <78629482+HeFuxiang94@users.noreply.github.com> Co-authored-by: jiyuyang <1041176461@qq.com> Co-authored-by: jiyuang <jiyuyang@mail.ustc.com> * New propagator for better Convergence (#2253) * New propagator for better Convergence * Add files via upload * Add files via upload * Modified the code's implementation approach. I have modified the implementation approach of the code, and this one involves less changes to the original code. It also includes handling for multiple k-points. * Delete module_esolver directory * Delete module_hamilt_general directory * Delete module_hamilt_lcao directory * Add files via upload * Update dipole.py (#2270) * Simplify matrix multiplication and add new propagator method (#2272) * Add the dipole and spectrum post-processing script. (#1928) * Add the Dipole and post-processing script necessary to calculate the spectrum using TDDFT. * fix td_val test bug. * Fix: bug in parsing strings mixed with " ", "\t" (#1951) * Use template to reconstruct parse_expression * Feature: output R matrix at each MD step * Modify'matrix_HS' to 'matrix' for R matrix output * Merge branches 'develop' and 'develop' of https://github.com/1041176461/abacus-develop into develop * Fix: modify index in parse_expression * Fix: bug in parsing strings mixed with " ", "\t" --------- Co-authored-by: jiyuang <jiyuyang@mail.ustc.com> * solve conflicts * solve conflicts * solve conflicts * solve conflicts * solve conflicts * Fix : bug of multi-kpoint for tddft (#2023) * fix bug of electric field in tddft * fix bug of dipole and electric field * fix bug of multi-kpoint for tddft * unit conversion of out_efield * delete useless paramters for tddft (td_val_elec*) * delete useless parameters for tddft * pack all changes in tddft * solve conflicts * delete td_val * simplify matrix multiplication and update new propagator for tddft * add autotests for new propagator * fix bug of ekb in tddft * delete temp output * update ref of new propagator * update CASES --------- Co-authored-by: HeFuxiang94 <78629482+HeFuxiang94@users.noreply.github.com> Co-authored-by: jiyuyang <1041176461@qq.com> Co-authored-by: jiyuang <jiyuyang@mail.ustc.com> Co-authored-by: Qianrui <76200646+Qianruipku@users.noreply.github.com> * delete td_htype and update ref of tddft autotests * delete td_htype * refactor tddft code * move read_paramter of electric field to input_conv.cpp for tddft * sve conflicts * move definition of tag * convert read_parameter * add namespace module_tddft * remove tmp file * move read_paramters of electric field in tddft to input_conv.cpp * add force of tddft efield * add annotations * move read_parameters from H_TDDFT_pw.cpp to input_conv.cpp * add ifdef __LCAO * remove input parameter of read_td_efield * remove input parameter of read_td_efield * fix bug for input UTs * change name of parameters of compute_force in H_TDDFT_pw.h * improve annotation * solve conflicts * solve conflicts * add UT for read_td_efield * add ifdef __LCAO * add ifdef __LCAO * mistake for TEST and TEST_F * fix ReadTdEfieldTest * fix ReadTdEfieldTest * add doublenear() for EXPECT_EQ in ReadEfieldTest * add nampspace for doublenear * add nampspace for doublenear * mistake * replace doublenear with EXPECT_NEAR * TEST_F * delete nband in propagator * add UT for module tddft * comment add_test * fix bug of prepare() in H_TDDFT_pw.cpp * split tddft_test * fix bug * fix bug of UT for tddft * add tddft prefix * add UT for cblacs_gridinit * fix bug of UT for tddft * fix bug of UT for tddft --------- Co-authored-by: HeFuxiang94 <78629482+HeFuxiang94@users.noreply.github.com> Co-authored-by: jiyuyang <1041176461@qq.com> Co-authored-by: jiyuang <jiyuyang@mail.ustc.com> Co-authored-by: HTZhao <104255052+ESROAMER@users.noreply.github.com> Co-authored-by: Omega <62006565+Satinelamp@users.noreply.github.com> Co-authored-by: Qianrui <76200646+Qianruipku@users.noreply.github.com> * Test: add module_io/bessel_basis unit test (#2614) * Test: module_io/bessel_basis unit test still leave readin_C4 and allocate_C4 two functions untested, will complete soon. * Update bessel_basis_test.cpp add annotations to describe tested functions * Revert "Refactor: output efermi in pw basis (#2604)" (#2616) This reverts commit a23df80. * const qualifiers appended --------- Co-authored-by: dyzheng <zhengdy@dp.tech> Co-authored-by: dyzheng <zhengdy@bjaisi.com> Co-authored-by: lyb9812 <88070104+lyb9812@users.noreply.github.com> Co-authored-by: HeFuxiang94 <78629482+HeFuxiang94@users.noreply.github.com> Co-authored-by: jiyuyang <1041176461@qq.com> Co-authored-by: jiyuang <jiyuyang@mail.ustc.com> Co-authored-by: HTZhao <104255052+ESROAMER@users.noreply.github.com> Co-authored-by: Omega <62006565+Satinelamp@users.noreply.github.com> Co-authored-by: Qianrui <76200646+Qianruipku@users.noreply.github.com> Co-authored-by: Yike Huang <67682086+kirk0830@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add unit tests for module_tddft.