Test: add precision tests for sphbesj#2958
Merged
dyzheng merged 7 commits intodeepmodeling:developfrom Sep 21, 2023
Merged
Conversation
jinzx10
suggested changes
Sep 15, 2023
jinzx10
left a comment
There was a problem hiding this comment.
It seems the current test grid is uniform. Is it possible to add some extra-fine sample points near 0, like 0.01, 0.001, 0.0001, 0.00001...? (no necessarily a log grid with base 10)
Author
|
I have added data points around 0 with a data range that spans from |
|
It seems sphbes.m still has some problems:
PS: if you feel writing a robust sphbes function is tedious and unnecessary, maybe removing those matlab/octave scripts is just fine. |
jinzx10
approved these changes
Sep 20, 2023
jinzx10
approved these changes
Sep 20, 2023
dyzheng
approved these changes
Sep 21, 2023
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In precision tests, we typically require strict benchmark data for comparison. For instance, in scientific computation, we often consider the calculation results from commercial software as the gold standard, like Matlab or Mathematica. In this commit, we utilized Octave, an open source software, to generate the Bessel function data points.
sphbesjpassed the precision tests where the threshold is set to1e-12.Spherical_Besselfailed to pass the tests (especially whenl = 4the error rises to1e-6) thusTEST_F(Sphbes, SeriesAndRecurrence)is removed.