Skip to content

In integrate test add force threshold of 0.0001 and stress threhold 0.001…#3088

Merged
hongriTianqi merged 9 commits intodeepmodeling:developfrom
Zhuxuegang2022:intergratetest
Oct 24, 2023
Merged

In integrate test add force threshold of 0.0001 and stress threhold 0.001…#3088
hongriTianqi merged 9 commits intodeepmodeling:developfrom
Zhuxuegang2022:intergratetest

Conversation

@Zhuxuegang2022
Copy link

…to made less warning output

Reminder

  • Have you linked an issue with this pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #2844

What's changed?

In integrate test add force threshold of 0.0001 and stress threhold of 0.001. this change will let less "warning" to output.

@hongriTianqi
Copy link

Please check to bash script, there might be an error to cause the warning in the picture:
截屏2023-10-23 09 53 22

@caic99
Copy link
Member

caic99 commented Oct 23, 2023

@Zhuxuegang2022 #2552 may be solved by remove all warnings in a new PR after merging this one.

Copy link
Collaborator

@dyzheng dyzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please format your code, tabs should be replace by spaces.

@caic99 caic99 requested a review from dyzheng October 23, 2023 11:32
Copy link
Collaborator

@dyzheng dyzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree to set force_threshold and stress_threshold to broaden criterion, because results of different compilers or machines may have small digital errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fifty integrated test cases failed on Intel env

4 participants