Skip to content

Rerevert 3228#3320

Merged
dyzheng merged 2 commits intodeepmodeling:has_rapidjsonfrom
dyzheng:rerevert
Dec 9, 2023
Merged

Rerevert 3228#3320
dyzheng merged 2 commits intodeepmodeling:has_rapidjsonfrom
dyzheng:rerevert

Conversation

@dyzheng
Copy link
Collaborator

@dyzheng dyzheng commented Dec 8, 2023

Reminder

  • Have you linked an issue with this pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #...

What's changed?

  • Example: My changes might affect the performance of the application under certain conditions, and I have tested the impact on various scenarios...

Any changes of core modules? (ignore if not applicable)

  • Example: I have added a new virtual function in the esolver base class in order to ...

@dyzheng dyzheng requested a review from pxlxingliang December 8, 2023 08:54
@dyzheng dyzheng merged commit e721bf7 into deepmodeling:has_rapidjson Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pxlxingliang pxlxingliang Awaiting requested review from pxlxingliang

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dyzheng