modify the reference of 184_PW_BNDKPAR_SDFT_MALL/ALL#3369
Merged
dyzheng merged 1 commit intodeepmodeling:developfrom Dec 22, 2023
Merged
modify the reference of 184_PW_BNDKPAR_SDFT_MALL/ALL#3369dyzheng merged 1 commit intodeepmodeling:developfrom
dyzheng merged 1 commit intodeepmodeling:developfrom
Conversation
60 tasks
dyzheng
approved these changes
Dec 22, 2023
Collaborator
dyzheng
left a comment
There was a problem hiding this comment.
I agree the change of references, but please pay attention to performance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reminder
Since #3175 modify the symmetry_prec from 1e-5 to 1e-6, 184_PW_BNDKPAR_SDFT_ALL/184_PW_BNDKPAR_SDFT_MALL will suffer warning.
Modify the reference to the value produced by latest codes.
Linked Issue
Fix #3242
What's changed?
Any changes of core modules? (ignore if not applicable)