Refactor: charge_mixing::set_mixing()#3596
Merged
WHUweiqingzhou merged 12 commits intodeepmodeling:developfrom Feb 4, 2024
Merged
Refactor: charge_mixing::set_mixing()#3596WHUweiqingzhou merged 12 commits intodeepmodeling:developfrom
WHUweiqingzhou merged 12 commits intodeepmodeling:developfrom
Conversation
WHUweiqingzhou
changed the title
dyzheng
approved these changes
Feb 4, 2024
Collaborator
dyzheng
left a comment
dyzheng
left a comment
There was a problem hiding this comment.
Refactoring of charge_mixing is necessary, this PR is a good start.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #3597.
List of Changes:
set_mixing()/reset()/mix_rho/mix_dmras pubilc incharge_mixing.h, and set other members as private.set_mixing(), and make sure all mixing parameters can be got by this interface.