Fix: fix the bug when reuse the numerical_basis class instance#3615
Merged
dyzheng merged 8 commits intodeepmodeling:developfrom Feb 28, 2024
Merged
Fix: fix the bug when reuse the numerical_basis class instance#3615dyzheng merged 8 commits intodeepmodeling:developfrom
dyzheng merged 8 commits intodeepmodeling:developfrom
Conversation
dyzheng
reviewed
Feb 20, 2024
dyzheng
reviewed
Feb 22, 2024
dyzheng
reviewed
Feb 22, 2024
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
N.B.
This PR is just an opening of refactor of old
Numerical_Basisclass. A framework of xml library will be beneficial for making several classes in ABACUS lighter and clean.Reminder
Linked Issue
Fix #3605
What's changed?
Numerical_Basismemory management is risky #3605Any changes of core modules? (ignore if not applicable)