Skip to content

Fix: fix the bug when reuse the numerical_basis class instance#3615

Merged
dyzheng merged 8 commits intodeepmodeling:developfrom
kirk0830:numerical_basis-1
Feb 28, 2024
Merged

Fix: fix the bug when reuse the numerical_basis class instance#3615
dyzheng merged 8 commits intodeepmodeling:developfrom
kirk0830:numerical_basis-1

Conversation

@kirk0830
Copy link
Collaborator

N.B.

This PR is just an opening of refactor of old Numerical_Basis class. A framework of xml library will be beneficial for making several classes in ABACUS lighter and clean.

Reminder

  • Have you linked an issue with this pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #3605

What's changed?

Any changes of core modules? (ignore if not applicable)

  • change esolver_ks_pw the numerical atomic orbital generation, the life span of numerical_basis instance.

@kirk0830 kirk0830 added the Bugs Bugs that only solvable with sufficient knowledge of DFT label Feb 18, 2024
Copy link
Collaborator

@dyzheng dyzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dyzheng dyzheng merged commit 67474ff into deepmodeling:develop Feb 28, 2024
@kirk0830 kirk0830 deleted the numerical_basis-1 branch March 9, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugs Bugs that only solvable with sufficient knowledge of DFT

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: present Numerical_Basis memory management is risky

3 participants