Fix FindLibxc.cmake to use /usr/include as include directory#3771
Merged
caic99 merged 1 commit intodeepmodeling:developfrom Mar 23, 2024
Merged
Fix FindLibxc.cmake to use /usr/include as include directory#3771caic99 merged 1 commit intodeepmodeling:developfrom
caic99 merged 1 commit intodeepmodeling:developfrom
Conversation
pkg-config would ignore flags like '-I/usr/include' in cflags; as ${prefix}_INCLUDE_DIRS is initialized from `pkg-config --cflags-only-I ${pkgname}`, it would be empty as only -I/usr/include in cflags. However, under this situation, cmake would still mark ${prefix}_FOUND as true, and without these global-visible includes no compilation issues arise; thus, this commit turns off detect of Libxc_INCLUDE_DIRS, and use Libxc_found instead.
caic99
approved these changes
Mar 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkg-config would ignore flags like
-I/usr/includein cflags; as${prefix}_INCLUDE_DIRS is initialized frompkg-config --cflags-only-I ${pkgname}, it would be empty as only-I/usr/includein cflags. However, under this situation, cmake would still mark${prefix}_FOUNDas true, and without these global-visible includes no compilation issues arise; thus, this commit turns off detect of Libxc_INCLUDE_DIRS, and use Libxc_found instead.Reminder
Linked Issue
Fix #3761
What's changed?
find_package_handle_standard_argsincmake/FindLibxc.cmake.Any changes of core modules? (ignore if not applicable)
No.