Refactor: clean up BLACS initialization in Parallel_2D#4207
Merged
mohanchen merged 3 commits intodeepmodeling:developfrom May 23, 2024
Merged
Refactor: clean up BLACS initialization in Parallel_2D#4207mohanchen merged 3 commits intodeepmodeling:developfrom
mohanchen merged 3 commits intodeepmodeling:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reminder
What's changed?
Code relevant to the initialization of BLACS grid & its information is made slightly easier to read & maintain.
This PR is just a stage-1; further refactoring towards more convenient manipulation on 2d-block-cyclic data structure will follow.
Question
I gather BLACS would split the given communicator to get some new ones for its own purpose when initializing the process grid, so it might be unnecessary to create a Cartesian MPI communicator in advance, which means we might get rid of the function mpi_create_cart(MPI_Comm). However, I'm not completely sure whether a Cartesian MPI grid would have performance benefit; this needs to be verified by an MPI/ScaLAPACK expert.
Any changes of core modules? (ignore if not applicable)
No.