Skip to content

Refactor: Seperate BLAS functions' declaration and implementation, and add a device_type flag for blas kernels#5242

Merged
mohanchen merged 20 commits intodeepmodeling:developfrom
Critsium-xy:dsp
Oct 17, 2024
Merged

Refactor: Seperate BLAS functions' declaration and implementation, and add a device_type flag for blas kernels#5242
mohanchen merged 20 commits intodeepmodeling:developfrom
Critsium-xy:dsp

Conversation

@Critsium-xy
Copy link
Collaborator

Separate blas_connector.h to two files: blas_connector.h and blas_connector.cpp
Only declarations are left in header file, and implementations are in cpp file. This is for future rework of operator modules and is a preparation for a generalized way to transplant ABACUS to other platforms.

@mohanchen mohanchen added the Features Needed The features are indeed needed, and developers should have sophisticated knowledge label Oct 16, 2024
@mohanchen mohanchen requested a review from haozhihan October 17, 2024 08:12
Copy link

@haozhihan haozhihan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mohanchen mohanchen merged commit 60c1f77 into deepmodeling:develop Oct 17, 2024
@Critsium-xy Critsium-xy deleted the dsp branch October 18, 2024 05:13
@YuLiu98 YuLiu98 mentioned this pull request Oct 20, 2024
16 tasks
Fisherd99 pushed a commit to Fisherd99/abacus-BSE that referenced this pull request Mar 31, 2025
…d add a device_type flag for blas kernels (deepmodeling#5242)

* Seperate blas kernels' declaration and definition

* Fix compilation bug

* Move cblas link part to header file

* Remove inline keyword

* Fix test compilation

* Fix

* Fix

* Fix library sequence

* Optimize link usage

* Fix test building error

* Fix limxc build failing

* Add device_type flag

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Features Needed The features are indeed needed, and developers should have sophisticated knowledge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants