Skip to content

Test: Fix a bug about MKL_SCALAPACK in CMakeLists.txt#6645

Merged
mohanchen merged 1 commit intodeepmodeling:developfrom
sunliang98:fix_test
Oct 27, 2025
Merged

Test: Fix a bug about MKL_SCALAPACK in CMakeLists.txt#6645
mohanchen merged 1 commit intodeepmodeling:developfrom
sunliang98:fix_test

Conversation

@sunliang98
Copy link
Collaborator

@sunliang98 sunliang98 commented Oct 27, 2025

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #...

Unit Tests and/or Case Tests for my changes

  • A unit test is added for each new feature or bug fix.

What's changed?

image
  • In the code above, MKL::MKL_SCALAPACK is already wrapped within the MKL::MKL target via the --start/end-group linker flags. Therefore, it should not be linked again directly in CMakeLists.txt to avoid duplication.

Any changes of core modules? (ignore if not applicable)

  • Example: I have added a new virtual function in the esolver base class in order to ...

@sunliang98 sunliang98 requested a review from mohanchen October 27, 2025 08:41
@mohanchen mohanchen added the Compile & CICD & Docs & Dependencies Issues related to compiling ABACUS label Oct 27, 2025
@mohanchen mohanchen merged commit 91d71e2 into deepmodeling:develop Oct 27, 2025
14 checks passed
@sunliang98 sunliang98 deleted the fix_test branch January 26, 2026 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Compile & CICD & Docs & Dependencies Issues related to compiling ABACUS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants