Fix the wrong HF Coulomb at nspin=2#6672
Merged
dyzheng merged 3 commits intodeepmodeling:LTSfrom Nov 13, 2025
Merged
Conversation
mohanchen
added
Bugs
dyzheng
approved these changes
Nov 13, 2025
Collaborator
dyzheng
left a comment
dyzheng
left a comment
There was a problem hiding this comment.
LTGM, I will cherry-pick it to develop branch
maki49
added a commit
to maki49/abacus-develop
that referenced
this pull request
Nov 17, 2025
* fix the wrong HF Coulomb at nspin=2 * update the test result * add the unit for parameter abs_vavelen_range
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks @PeizeLin @Fisherd99 for finding the bug.
Please cherry-pick this commit into develop branch after merging.