Skip to content

[Feature]A new -i/-I/--info argument to show details of configuration and compilation #6734

Merged
mohanchen merged 73 commits intodeepmodeling:developfrom
ZhouXY-PKU:ZhouXY-PKU-abacus-info
Dec 1, 2025
Merged

[Feature]A new -i/-I/--info argument to show details of configuration and compilation #6734
mohanchen merged 73 commits intodeepmodeling:developfrom
ZhouXY-PKU:ZhouXY-PKU-abacus-info

Conversation

@ZhouXY-PKU
Copy link
Collaborator

@ZhouXY-PKU ZhouXY-PKU commented Nov 25, 2025

Linked Issue

Fix #6686

Unit Tests and/or Case Tests for my changes

  • The unit test for parse_args.cpp has been updated.

What's changed?

  • A header file build_info.h will be generated after cmake/make configuration process, so "out of source construction" is necessary now. source/Makefile has been modified to support "out of source construction".

What's "out of source construction"?

To build in a individual directory like build

mkdir build && cd build
cmake ../ -D...
or
make -f ../source/Makefile ... 

Acknowledgements

Thanks for reviews from @QuantumMisaka ; thanks for tests on various computation platforms including DSP/SW/GPU by @Critsium-xy and @Cstandardlib .

Added a function to print detailed build information, including version, compiler info, and library support. Updated argument parsing to include a new option for displaying build info.
Added header guards and updated namespace for ModuleIO.
Refactor CMakeLists.txt to improve build information collection and include RapidJSON path.
Updated function documentation for clarity and corrected a typo.
Removed unused functions and added new JSON-related functions.
@ZhouXY-PKU ZhouXY-PKU marked this pull request as draft November 25, 2025 09:20
@mohanchen mohanchen added Features Needed The features are indeed needed, and developers should have sophisticated knowledge Refactor Refactor ABACUS codes labels Nov 25, 2025
@ZhouXY-PKU ZhouXY-PKU requested review from QuantumMisaka and mohanchen and removed request for QuantumMisaka and mohanchen November 25, 2025 15:09
@ZhouXY-PKU ZhouXY-PKU marked this pull request as ready for review November 29, 2025 01:46
@ZhouXY-PKU ZhouXY-PKU changed the title [Feature]A new -i/-I/--info argument to show the details of the compilation [Feature]A new -i/-I/--info argument to show details of configuration and compilation Nov 29, 2025
@QuantumMisaka
Copy link
Collaborator

LGTM.

The only existing drawback is that CUDA-Aware MPI detection has only OpenMPI interface but not including MPICH/Intelmpi, but that is not very important.

Good to merge !

@ZhouXY-PKU
Copy link
Collaborator Author

LGTM.

The only existing drawback is that CUDA-Aware MPI detection has only OpenMPI interface but not including MPICH/Intelmpi, but that is not very important.

Good to merge !

Thanks for your reviews!I have just found that ctests are all skipped now,and I need to figure out what has happened...

Copy link
Collaborator

@mohanchen mohanchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the tests need to pass

@ZhouXY-PKU ZhouXY-PKU requested a review from mohanchen December 1, 2025 11:30
@mohanchen mohanchen merged commit f671ce1 into deepmodeling:develop Dec 1, 2025
14 checks passed
@ZhouXY-PKU ZhouXY-PKU deleted the ZhouXY-PKU-abacus-info branch December 15, 2025 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Features Needed The features are indeed needed, and developers should have sophisticated knowledge Refactor Refactor ABACUS codes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]Outputs of abacus --version need more details

3 participants