Skip to content

Fix energy jumps occur in rt-TDDFT calculations#6779

Merged
mohanchen merged 3 commits intodeepmodeling:developfrom
ESROAMER:develop
Dec 13, 2025
Merged

Fix energy jumps occur in rt-TDDFT calculations#6779
mohanchen merged 3 commits intodeepmodeling:developfrom
ESROAMER:develop

Conversation

@ESROAMER
Copy link
Collaborator

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #6778

What's changed?

To fix the discontinuity caused by ions crossing boundaries, an additional phase must be added to the relevant matrix each time a crossing occurs. Here are the results after applying the fix.
Comparison_plot

Any changes of core modules? (ignore if not applicable)

An additional member variable boundary_shift was added to the class Atom to track ion boundary crossings.

@mohanchen
Copy link
Collaborator

Nice job!

@mohanchen mohanchen added Bugs Bugs that only solvable with sufficient knowledge of DFT Refactor Refactor ABACUS codes labels Dec 13, 2025
Copy link
Collaborator

@AsTonyshment AsTonyshment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@mohanchen mohanchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mohanchen mohanchen merged commit d010cc0 into deepmodeling:develop Dec 13, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugs Bugs that only solvable with sufficient knowledge of DFT Refactor Refactor ABACUS codes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Energy jumps occur in rt-TDDFT calculations.

3 participants