Simplify Lmax and rmesh in Matrix_Orbs and Center2_Orb#6829
Merged
mohanchen merged 18 commits intodeepmodeling:developfrom Jan 7, 2026
Merged
Simplify Lmax and rmesh in Matrix_Orbs and Center2_Orb#6829mohanchen merged 18 commits intodeepmodeling:developfrom
mohanchen merged 18 commits intodeepmodeling:developfrom
Conversation
…Lmax to local variable
2. Refactor Lmax of Sph_Bessel_Recursive
2. delete useless Center2_Orb::init_Lmax()
Conflicts: source/source_lcao/center2_orb.cpp source/source_lcao/module_ri/ABFs_Construct-PCA.cpp source/source_lcao/module_ri/LRI_CV.hpp source/source_lcao/module_ri/Matrix_Orbs11.cpp source/source_lcao/module_ri/Matrix_Orbs11.h source/source_lcao/module_ri/Matrix_Orbs21.cpp source/source_lcao/module_ri/Matrix_Orbs21.h source/source_lcao/module_ri/Matrix_Orbs22.cpp source/source_lcao/module_ri/Matrix_Orbs22.h source/source_lcao/module_ri/exx_opt_orb.cpp
Conflicts: source/source_lcao/module_ri/ABFs_Construct-PCA.cpp
Conflicts: source/source_lcao/center2_orb.cpp source/source_lcao/module_ri/ABFs_Construct-PCA.cpp source/source_lcao/module_ri/Exx_LRI_interface.hpp source/source_lcao/module_ri/LRI_CV.hpp source/source_lcao/module_ri/Matrix_Orbs11.cpp source/source_lcao/module_ri/Matrix_Orbs11.h source/source_lcao/module_ri/Matrix_Orbs21.cpp source/source_lcao/module_ri/Matrix_Orbs21.h source/source_lcao/module_ri/Matrix_Orbs22.cpp source/source_lcao/module_ri/Matrix_Orbs22.h source/source_lcao/module_ri/RPA_LRI.hpp source/source_lcao/module_ri/exx_abfs.h source/source_lcao/module_ri/exx_opt_orb.cpp
linpeize
force-pushed
the
Lmax_center2_3
branch
from
2c81b88 to
0385811
Compare
linpeize
force-pushed
the
Lmax_center2_3
branch
from
0385811 to
275442c
Compare
mohanchen
reviewed
Jan 5, 2026
mohanchen
added
Refactor
linpeize
force-pushed
the
Lmax_center2_3
branch
from
695dc42 to
64d73a9
Compare
mohanchen
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.