Refactor Parallel_Reduce: Replace manual gather-reduce with MPI_Allreduce#6922
Merged
mohanchen merged 13 commits intodeepmodeling:developfrom Jan 29, 2026
Merged
Refactor Parallel_Reduce: Replace manual gather-reduce with MPI_Allreduce#6922mohanchen merged 13 commits intodeepmodeling:developfrom
mohanchen merged 13 commits intodeepmodeling:developfrom
Conversation
mohanchen
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the
Parallel_Reduceclass to useMPI_Allreducedirectly for minimum and maximum operations, replacing the previous implementation that usedMPI_Allgatherfollowed by local reduction. This change simplifies the code, reduces memory overhead, and unifies the reduction interface.Key Changes
Refactored
Parallel_ReduceImplementation:gather_min_int_allwithreduce_min_int.gather_max/min_double_allwithreduce_max/min_double.gather_max/min_double_poolwithreduce_max/min_double_pool.MPI_AllreducewithMPI_MIN/MPI_MAXfor better efficiency.Updated Call Sites:
source/source_estate/,source/source_pw/,source/source_lcao/, and other modules to match the new API.#ifdef __MPIguards in caller functions, as theParallel_Reducewrappers now handle MPI conditional compilation internally.Cleanup:
parallel_reduce_test.cpp.Impact