Fix: Fix RT-TDDFT segmentation fault caused by unconverged initial SCF#6954
Merged
mohanchen merged 1 commit intodeepmodeling:developfrom Feb 8, 2026
Merged
Conversation
mohanchen
approved these changes
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a critical segmentation fault in the RT-TDDFT module when the initial Ground State SCF calculation fails to converge within the specified
scf_nmax.Issue & Root Cause
Scenario:
scf_nmax.conv_esolveris false).Evolve_elec::solve_psiwhen accessingpsi_laststep.Root Cause:
In
source/source_esolver/esolver_ks_lcao_tddft.cpp, the functionstore_h_s_psi(responsible for allocating and savingpsi_laststep,Hk_laststep,Sk_laststep) was only called ifconv_esolverwastrue.When SCF failed to converge,
psi_laststepremained anullptr. Subsequently, callingpsi_laststep->fix_k(ik)in the next step triggered a segmentation fault.Fix
Modified
ESolver_KS_LCAO_TDDFT::iter_finishto allow storing the wavefunction and Hamiltonian/Overlap matrices even if convergence is not reached, provided the iteration count has hit the limit (iter == this->maxniter).