Skip to content

Fix C++17 inline constexpr to support C++11 #6957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mohanchen merged 2 commits into from
Feb 8, 2026
Merged

Fix C++17 inline constexpr to support C++11 #6957

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6127784
Fix C++17 inline constexpr to support C++11
dzzz2001 Feb 8, 2026
d331a13
Merge branch 'develop' into fix-6956-cpp17-inline-constexpr
dzzz2001 Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion source/source_base/ylmcoef.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ constexpr int YLMCOEF_SIZE = 36;
// GPU version: must use numeric constants (CUDA doesn't support runtime init for __device__)
__device__ static const double ylmcoef[YLMCOEF_SIZE] = {
#else
inline constexpr double ylmcoef[YLMCOEF_SIZE] = {
// Use static constexpr for C++11 compatibility (inline variables require C++17)
static constexpr double ylmcoef[YLMCOEF_SIZE] = {
#endif
0.28209479177387813964, // 1.0 / sqrt(ModuleBase::FOUR_PI)
0.48860251190291992263, // sqrt (3.0 / ModuleBase::FOUR_PI)
Expand Down
Loading