Skip to content

fix Fail to build on macos: explicit instantiation of 'deepmd::Region' must occur in namespace 'deepmd'#1071

Merged
amcadmus merged 1 commit intodeepmodeling:develfrom
amcadmus:fix-1070
Aug 31, 2021
Merged

fix Fail to build on macos: explicit instantiation of 'deepmd::Region' must occur in namespace 'deepmd'#1071
amcadmus merged 1 commit intodeepmodeling:develfrom
amcadmus:fix-1070

Conversation

@amcadmus
Copy link
Member

No description provided.

@amcadmus amcadmus requested a review from njzjz August 31, 2021 02:06
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2021

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.16%. Comparing base (a7e4760) to head (fd81a53).
Report is 1487 commits behind head on devel.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #1071      +/-   ##
==========================================
+ Coverage   75.10%   75.16%   +0.06%     
==========================================
  Files          87       87              
  Lines        6953     6959       +6     
==========================================
+ Hits         5222     5231       +9     
+ Misses       1731     1728       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@njzjz njzjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm it works.

@amcadmus amcadmus merged commit 75160c7 into deepmodeling:devel Aug 31, 2021
@amcadmus amcadmus deleted the fix-1070 branch September 8, 2021 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants