Skip to content

Revert "get library extension suffix from built-in method"#1072

Merged
amcadmus merged 1 commit intodevelfrom
revert-1036-libext
Sep 1, 2021
Merged

Revert "get library extension suffix from built-in method"#1072
amcadmus merged 1 commit intodevelfrom
revert-1036-libext

Conversation

@njzjz
Copy link
Member

@njzjz njzjz commented Aug 31, 2021

Reverts #1036

It doesn't work on macos, so I'm going to revert.

@njzjz njzjz requested a review from amcadmus August 31, 2021 03:20
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2021

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.15%. Comparing base (75160c7) to head (bcb61e8).
Report is 1479 commits behind head on devel.

Files Patch % Lines
deepmd/env.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #1072      +/-   ##
==========================================
- Coverage   75.19%   75.15%   -0.04%     
==========================================
  Files          82       87       +5     
  Lines        6945     6963      +18     
==========================================
+ Hits         5222     5233      +11     
- Misses       1723     1730       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amcadmus amcadmus merged commit 5e96c57 into devel Sep 1, 2021
@amcadmus amcadmus deleted the revert-1036-libext branch September 1, 2021 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants