Skip to content

Fix bug of single precision transfer#1111

Merged
amcadmus merged 1 commit intodeepmodeling:develfrom
denghuilu:float-transfer
Sep 7, 2021
Merged

Fix bug of single precision transfer#1111
amcadmus merged 1 commit intodeepmodeling:develfrom
denghuilu:float-transfer

Conversation

@denghuilu
Copy link
Member

The same problem as #1110.

@denghuilu denghuilu requested a review from amcadmus September 6, 2021 15:09
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2021

Codecov Report

Merging #1111 (8500517) into devel (8727956) will decrease coverage by 1.25%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel    #1111      +/-   ##
==========================================
- Coverage   75.62%   74.37%   -1.26%     
==========================================
  Files          88       88              
  Lines        7012     6996      -16     
==========================================
- Hits         5303     5203     -100     
- Misses       1709     1793      +84     
Impacted Files Coverage Δ
deepmd/entrypoints/transfer.py 72.54% <50.00%> (ø)
deepmd/infer/deep_tensor.py 56.09% <0.00%> (-39.03%) ⬇️
deepmd/train/run_options.py 71.42% <0.00%> (-15.37%) ⬇️
deepmd/loggers/loggers.py 41.90% <0.00%> (-9.53%) ⬇️
source/op/_gelu.py 71.42% <0.00%> (-6.35%) ⬇️
deepmd/train/trainer.py 69.81% <0.00%> (-2.21%) ⬇️
deepmd/env.py 73.33% <0.00%> (-1.12%) ⬇️
deepmd/loss/ener.py 47.34% <0.00%> (-0.24%) ⬇️
source/op/_tabulate_grad.py 100.00% <0.00%> (ø)
source/op/_prod_force_grad.py 100.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8727956...8500517. Read the comment docs.

@amcadmus amcadmus merged commit 2a71494 into deepmodeling:devel Sep 7, 2021
njzjz added a commit to njzjz/deepmd-kit that referenced this pull request Sep 21, 2023
When turning on the merge_traj function, if the procedure is interrupted
in the run_model_devi stage, the old trajectory file will be overwritten
after it is rerun. The incomplete trajectory file will cause the
following error in the next post_model_devi stage:
`.../site-packages/dpdata/lammps/dump.py:176: VisibleDeprecationWarning:
Creating an ndarray from ragged nested sequences (which is a
list-or-tuple of lists-or-tuples-or ndarrays with different lengths or
shapes) is deprecated. If you meant to do this, you must specify
'dtype=object' when creating the ndarray.
system['coords'] = np.array(system['coords'])
DeepModeling
`
This PR repaired this question.

---------

Signed-off-by: kiwi <46419582+wankiwi@users.noreply.github.com>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Co-authored-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants