fix LAMMPS_VERSION_NUMBER condition#1116
Merged
amcadmus merged 1 commit intodeepmodeling:develfrom Sep 8, 2021
Merged
Conversation
When I debug deepmodeling#1109, I accidentally find the LAMMPS_VERSION_NUMBER condition is wrong, making builds fail. (but this is not related to deepmodeling#1109)
Codecov Report
@@ Coverage Diff @@
## devel #1116 +/- ##
===========================================
- Coverage 75.61% 64.28% -11.33%
===========================================
Files 88 5 -83
Lines 7016 14 -7002
===========================================
- Hits 5305 9 -5296
+ Misses 1711 5 -1706 Continue to review full report at Codecov.
|
amcadmus
approved these changes
Sep 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I debug #1109, I accidentally find the LAMMPS_VERSION_NUMBER condition is wrong, making builds fail. (but this is not related to #1109)