Skip to content

fix LAMMPS_VERSION_NUMBER condition#1116

Merged
amcadmus merged 1 commit intodeepmodeling:develfrom
njzjz:build_number
Sep 8, 2021
Merged

fix LAMMPS_VERSION_NUMBER condition#1116
amcadmus merged 1 commit intodeepmodeling:develfrom
njzjz:build_number

Conversation

@njzjz
Copy link
Member

@njzjz njzjz commented Sep 8, 2021

When I debug #1109, I accidentally find the LAMMPS_VERSION_NUMBER condition is wrong, making builds fail. (but this is not related to #1109)

When I debug deepmodeling#1109, I accidentally find the LAMMPS_VERSION_NUMBER condition is wrong, making builds fail. (but this is not related to deepmodeling#1109)
@codecov-commenter
Copy link

Codecov Report

Merging #1116 (b9d1d08) into devel (2a71494) will decrease coverage by 11.32%.
The diff coverage is n/a.

❗ Current head b9d1d08 differs from pull request most recent head 800a1ef. Consider uploading reports for the commit 800a1ef to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##            devel    #1116       +/-   ##
===========================================
- Coverage   75.61%   64.28%   -11.33%     
===========================================
  Files          88        5       -83     
  Lines        7016       14     -7002     
===========================================
- Hits         5305        9     -5296     
+ Misses       1711        5     -1706     
Impacted Files Coverage Δ
deepmd/entrypoints/compress.py
deepmd/infer/model_devi.py
deepmd/utils/data_system.py
deepmd/utils/tabulate.py
deepmd/entrypoints/__init__.py
deepmd/__main__.py
deepmd/__init__.py
deepmd/loggers/__init__.py
deepmd/utils/weight_avg.py
source/op/_gelu.py
... and 73 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a71494...800a1ef. Read the comment docs.

@amcadmus amcadmus merged commit 1fbf474 into deepmodeling:devel Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants