fix "Call to method DeepTensor.__init__ with too many arguments"#1125
Merged
amcadmus merged 1 commit intodeepmodeling:develfrom Sep 10, 2021
Merged
fix "Call to method DeepTensor.__init__ with too many arguments"#1125amcadmus merged 1 commit intodeepmodeling:develfrom
amcadmus merged 1 commit intodeepmodeling:develfrom
Conversation
As detected by LGTM, here is an error: Call to method DeepTensor.__init__ with too many arguments; should be no more than 4. I agree with the automatic code analysis tool.
Codecov Report
@@ Coverage Diff @@
## devel #1125 +/- ##
===========================================
- Coverage 75.10% 64.28% -10.82%
===========================================
Files 87 5 -82
Lines 6953 14 -6939
===========================================
- Hits 5222 9 -5213
+ Misses 1731 5 -1726 Continue to review full report at Codecov.
|
amcadmus
approved these changes
Sep 10, 2021
Member
amcadmus
left a comment
amcadmus
left a comment
There was a problem hiding this comment.
Actually the class DeepGlobalPolar is not used by deepmd-kit anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As detected by LGTM, here is an error:
Call to method DeepTensor.init with too many arguments; should be no more than 4.
I agree with the automatic code analysis tool.