Skip to content

Add doc for model deviation#1153

Merged
amcadmus merged 4 commits intodeepmodeling:develfrom
AnguseZhang:devel
Sep 17, 2021
Merged

Add doc for model deviation#1153
amcadmus merged 4 commits intodeepmodeling:develfrom
AnguseZhang:devel

Conversation

@AnguseZhang
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2021

Codecov Report

Merging #1153 (98edd0b) into devel (424970e) will decrease coverage by 11.38%.
The diff coverage is n/a.

❗ Current head 98edd0b differs from pull request most recent head 4f0f95c. Consider uploading reports for the commit 4f0f95c to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##            devel    #1153       +/-   ##
===========================================
- Coverage   75.66%   64.28%   -11.39%     
===========================================
  Files          89        5       -84     
  Lines        7048       14     -7034     
===========================================
- Hits         5333        9     -5324     
+ Misses       1715        5     -1710     
Impacted Files Coverage Δ
deepmd/descriptor/hybrid.py
deepmd/fit/dipole.py
deepmd/__init__.py
source/op/_soft_min_force_grad.py
deepmd/infer/deep_pot.py
deepmd/descriptor/se_t.py
deepmd/op/__init__.py
deepmd/loggers/loggers.py
deepmd/infer/deep_eval.py
deepmd/utils/weight_avg.py
... and 74 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 424970e...4f0f95c. Read the comment docs.

- models = frozen model(s) to compute the interaction. If multiple models are provided, then the model deviation will be computed
- models = frozen model(s) to compute the interaction.
If multiple models are provided, then only the first model serves to provide energy and force prediction for molecular dynamics,
and the model deviation will be computed among all models.
Copy link
Member

@njzjz njzjz Sep 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The energy and force will be computed every step, but the model deviation will be only computed every out_freq steps.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@njzjz plz suggest a change.

Co-authored-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@amcadmus amcadmus enabled auto-merge (squash) September 17, 2021 06:27
@amcadmus amcadmus merged commit 077df3d into deepmodeling:devel Sep 17, 2021
njzjz added a commit to njzjz/deepmd-kit that referenced this pull request Sep 26, 2021
amcadmus pushed a commit that referenced this pull request Sep 28, 2021
* move AutoBatchSize from dp test to dp.eval

Bugfix.

* Revert "Bug fix of memory overflow when calculating model deviation (#1153)"

This reverts commit d8acbb8.

* reshape coords before get shape

* use the same AutoBatchSize for all models in model deviation
njzjz pushed a commit to njzjz/deepmd-kit that referenced this pull request Sep 21, 2023
…t_fp_abacus_scf() (deepmodeling#1153)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants