automatic batch size for dp test#1165
Merged
amcadmus merged 3 commits intodeepmodeling:develfrom Sep 24, 2021
Merged
Conversation
Resolves deepmodeling#1149. We start nbatch * natoms from 1024 (or we can set a different number), and iteratively multiply it by 2 until catching the OOM error. A small issue is that it's a bit slow to catch the TF OOM error. It's a problem of TF and I don't know how to resolve it. Luckily we only need to catch once.
Codecov Report
@@ Coverage Diff @@
## devel #1165 +/- ##
==========================================
+ Coverage 75.94% 76.08% +0.13%
==========================================
Files 90 91 +1
Lines 7172 7226 +54
==========================================
+ Hits 5447 5498 +51
- Misses 1725 1728 +3
Continue to review full report at Codecov.
|
amcadmus
reviewed
Sep 23, 2021
deepmd/utils/batch_size.py
Outdated
| self.maximum_working_batch_size = 0 | ||
| self.minimal_not_working_batch_size = 2**31 | ||
|
|
||
| def execuate(self, callable: Callable, start_index: int, natoms: int) -> Tuple[int, tuple]: |
amcadmus
reviewed
Sep 23, 2021
Member
amcadmus
left a comment
amcadmus
left a comment
There was a problem hiding this comment.
Could you please add a unittest for the AutoBatchSize?
amcadmus
approved these changes
Sep 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1149.
We start nbatch * natoms from 1024 (or we can set a different number), and iteratively multiply it by 2 until catching the OOM error.
A small issue is that it's a bit slow to catch the TF OOM error. It's a problem of TF and I don't know how to resolve it. Luckily we only need to catch once.