fix single precision model compression error#1212
Merged
wanghan-iapcm merged 1 commit intodeepmodeling:develfrom Oct 15, 2021
Merged
fix single precision model compression error#1212wanghan-iapcm merged 1 commit intodeepmodeling:develfrom
wanghan-iapcm merged 1 commit intodeepmodeling:develfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## devel #1212 +/- ##
==========================================
- Coverage 76.04% 75.98% -0.07%
==========================================
Files 91 86 -5
Lines 7260 7245 -15
==========================================
- Hits 5521 5505 -16
- Misses 1739 1740 +1
Continue to review full report at Codecov.
|
njzjz
approved these changes
Oct 14, 2021
njzjz
added a commit
to njzjz/deepmd-kit
that referenced
this pull request
Sep 21, 2023
The `from_struct["atom_types"]` used to be a list but was changed to numpy array lately, thereby introducing a bug in `make_supercell_abacus` function. Also, the key `types` is changed to `atom_types` outside the function, but not changed in the function. This commit fix the two bugs. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's an error when using the single precision model compression:
This fault is mainly caused by the default type setting of the custom op TabulateFusion.
This PR should fix this problem.