calculate neighbor statistics from CLI#1476
Merged
wanghan-iapcm merged 5 commits intodeepmodeling:develfrom Feb 17, 2022
Merged
calculate neighbor statistics from CLI#1476wanghan-iapcm merged 5 commits intodeepmodeling:develfrom
wanghan-iapcm merged 5 commits intodeepmodeling:develfrom
Conversation
In many cases, we need to confirm neighbor statistics before training. This command provides such CLI option.
Codecov Report
@@ Coverage Diff @@
## devel #1476 +/- ##
===========================================
- Coverage 75.68% 64.28% -11.41%
===========================================
Files 92 5 -87
Lines 7671 14 -7657
===========================================
- Hits 5806 9 -5797
+ Misses 1865 5 -1860 Continue to review full report at Codecov.
|
Collaborator
wanghan-iapcm
left a comment
wanghan-iapcm
left a comment
There was a problem hiding this comment.
Could you please:
- add to the document showing how it works.
- add a unittest for
neighbor_stat
Thanks!
njzjz
commented
Feb 15, 2022
Comment on lines
+34
to
+36
| # set rcut to 0. will cause a core dumped | ||
| # TODO: check what is wrong | ||
| for rcut in (3., 6., 11.): |
Member
Author
There was a problem hiding this comment.
@denghuilu setting rcut to 0. will cause "core dumped". Any ideas?
Member
Author
There was a problem hiding this comment.
(Although, I don't think some one will set it to 0)
Member
There was a problem hiding this comment.
It might be caused by this line:
deepmd-kit/source/lib/src/neighbor_list.cc
Line 665 in 159e45d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In many cases, we need to confirm neighbor statistics before training.
This command provides such CLI option.