convert constants (which may change) to variables#1606
Merged
amcadmus merged 5 commits intodeepmodeling:develfrom Mar 29, 2022
Merged
convert constants (which may change) to variables#1606amcadmus merged 5 commits intodeepmodeling:develfrom
amcadmus merged 5 commits intodeepmodeling:develfrom
Conversation
Following deepmodeling#1592, I noticed that constants cannot be recovered when restart training.
Codecov Report
@@ Coverage Diff @@
## devel #1606 +/- ##
===========================================
- Coverage 76.56% 64.28% -12.28%
===========================================
Files 93 5 -88
Lines 7817 14 -7803
===========================================
- Hits 5985 9 -5976
+ Misses 1832 5 -1827 Continue to review full report at Codecov.
|
wanghan-iapcm
approved these changes
Mar 28, 2022
amcadmus
approved these changes
Mar 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #1592, I noticed that constants cannot be recovered when restart training.
(but it can be recovered automatically if it is a variable instead)