Skip to content

convert constants (which may change) to variables#1606

Merged
amcadmus merged 5 commits intodeepmodeling:develfrom
njzjz:variable
Mar 29, 2022
Merged

convert constants (which may change) to variables#1606
amcadmus merged 5 commits intodeepmodeling:develfrom
njzjz:variable

Conversation

@njzjz
Copy link
Member

@njzjz njzjz commented Mar 28, 2022

Following #1592, I noticed that constants cannot be recovered when restart training.

(but it can be recovered automatically if it is a variable instead)

Following deepmodeling#1592, I noticed that constants cannot be recovered when restart training.
@njzjz njzjz requested a review from wanghan-iapcm March 28, 2022 02:24
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2022

Codecov Report

Merging #1606 (602a8e2) into devel (8d4d93d) will decrease coverage by 12.27%.
The diff coverage is n/a.

❗ Current head 602a8e2 differs from pull request most recent head d507646. Consider uploading reports for the commit d507646 to get more accurate results

@@             Coverage Diff             @@
##            devel    #1606       +/-   ##
===========================================
- Coverage   76.56%   64.28%   -12.28%     
===========================================
  Files          93        5       -88     
  Lines        7817       14     -7803     
===========================================
- Hits         5985        9     -5976     
+ Misses       1832        5     -1827     
Impacted Files Coverage Δ
deepmd/descriptor/se_a.py
deepmd/fit/ener.py
deepmd/entrypoints/__init__.py
source/op/_prod_virial_grad.py
deepmd/entrypoints/compress.py
deepmd/entrypoints/config.py
deepmd/infer/deep_dipole.py
deepmd/utils/path.py
deepmd/utils/graph.py
deepmd/utils/sess.py
... and 78 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d4d93d...d507646. Read the comment docs.

@njzjz njzjz marked this pull request as draft March 28, 2022 04:00
@njzjz njzjz marked this pull request as ready for review March 28, 2022 04:07
@njzjz njzjz marked this pull request as draft March 28, 2022 10:21
@njzjz njzjz marked this pull request as ready for review March 28, 2022 10:27
@amcadmus amcadmus merged commit 398258a into deepmodeling:devel Mar 29, 2022
@njzjz njzjz deleted the variable branch March 29, 2022 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants