optimize the graph of dplr data modifier#1615
Merged
wanghan-iapcm merged 1 commit intodeepmodeling:develfrom Apr 2, 2022
Merged
optimize the graph of dplr data modifier#1615wanghan-iapcm merged 1 commit intodeepmodeling:develfrom
wanghan-iapcm merged 1 commit intodeepmodeling:develfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## devel #1615 +/- ##
==========================================
- Coverage 76.32% 76.16% -0.16%
==========================================
Files 94 94
Lines 7868 7849 -19
==========================================
- Hits 6005 5978 -27
- Misses 1863 1871 +8
Continue to review full report at Codecov.
|
njzjz
approved these changes
Apr 1, 2022
wanghan-iapcm
approved these changes
Apr 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite the dplr data modifier graph to use head gradient instead of looping over the Jacobian. This should largely reduce the graph size and can also improve the computation speed.