fix rcut in hybrid model compression#1663
Merged
wanghan-iapcm merged 2 commits intodeepmodeling:develfrom Apr 29, 2022
Merged
Conversation
The current way `self.graph.get_operation_by_name('ProdEnvMatA')` to get `rcut` is incorrect for hybrid models. There may be several ProdEnvMatA ops in a graph.
(cherry picked from commit 34a4e9b)
Codecov Report
@@ Coverage Diff @@
## devel #1663 +/- ##
==========================================
+ Coverage 76.15% 76.22% +0.07%
==========================================
Files 94 94
Lines 7850 7836 -14
==========================================
- Hits 5978 5973 -5
+ Misses 1872 1863 -9
Continue to review full report at Codecov.
|
wanghan-iapcm
approved these changes
Apr 28, 2022
denghuilu
approved these changes
Apr 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current way
self.graph.get_operation_by_name('ProdEnvMatA')to getrcutis incorrect for hybrid models. There may be several ProdEnvMatA ops in a graph.