Skip to content

Change Typo#1687

Merged
wanghan-iapcm merged 2 commits intodeepmodeling:develfrom
likefallwind:patch-1
May 9, 2022
Merged

Change Typo#1687
wanghan-iapcm merged 2 commits intodeepmodeling:develfrom
likefallwind:patch-1

Conversation

@likefallwind
Copy link
Member

"short" --> "shot"

"short" --> "shot"
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2022

Codecov Report

Merging #1687 (fc174ac) into devel (087ae56) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            devel    #1687      +/-   ##
==========================================
- Coverage   76.07%   76.02%   -0.06%     
==========================================
  Files          94       94              
  Lines        7863     7832      -31     
==========================================
- Hits         5982     5954      -28     
+ Misses       1881     1878       -3     
Impacted Files Coverage Δ
deepmd/loss/ener.py 47.57% <0.00%> (-0.23%) ⬇️
deepmd/utils/argcheck.py 90.06% <0.00%> (-0.20%) ⬇️
deepmd/common.py 82.27% <0.00%> (-0.12%) ⬇️
deepmd/train/run_options.py 88.57% <0.00%> (-0.11%) ⬇️
deepmd/train/trainer.py 79.25% <0.00%> (-0.10%) ⬇️
deepmd/descriptor/loc_frame.py 96.18% <0.00%> (-0.03%) ⬇️
deepmd/descriptor/se_a.py 95.67% <0.00%> (-0.02%) ⬇️
deepmd/descriptor/se_t.py 97.35% <0.00%> (-0.02%) ⬇️
source/op/_tabulate_grad.py 100.00% <0.00%> (ø)
source/op/_prod_force_grad.py 100.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 087ae56...fc174ac. Read the comment docs.

@njzjz
Copy link
Member

njzjz commented May 7, 2022

The markdown file index.md is also required to fix.

The DeePMD-kit organize data in `systems`. Each `system` is composed by a number of `frames`. One may roughly view a `frame` as a snap short on an MD trajectory, but it does not necessary come from an MD simulation. A `frame` records the coordinates and types of atoms, cell vectors if the periodic boundary condition is assumed, energy, atomic forces and virial. It is noted that the `frames` in one `system` share the same number of atoms with the same type.

@likefallwind
Copy link
Member Author

The markdown file index.md is also required to fix.

The DeePMD-kit organize data in `systems`. Each `system` is composed by a number of `frames`. One may roughly view a `frame` as a snap short on an MD trajectory, but it does not necessary come from an MD simulation. A `frame` records the coordinates and types of atoms, cell vectors if the periodic boundary condition is assumed, energy, atomic forces and virial. It is noted that the `frames` in one `system` share the same number of atoms with the same type.

ok I have fix it

@wanghan-iapcm wanghan-iapcm merged commit f275ce7 into deepmodeling:devel May 9, 2022
mingzhong15 pushed a commit to mingzhong15/deepmd-kit that referenced this pull request Jan 15, 2023
* Change Typo

"short" --> "shot"

* Update index.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants