set default fparam and aparam stat and recover from graph#1695
Merged
wanghan-iapcm merged 2 commits intodeepmodeling:develfrom May 11, 2022
Merged
set default fparam and aparam stat and recover from graph#1695wanghan-iapcm merged 2 commits intodeepmodeling:develfrom
wanghan-iapcm merged 2 commits intodeepmodeling:develfrom
Conversation
wanghan-iapcm
approved these changes
May 10, 2022
deepmd/fit/ener.py
Outdated
Comment on lines
+382
to
+383
| self.fparam_avg = 0. | ||
| self.fparam_inv_std = 1. |
Collaborator
There was a problem hiding this comment.
if self.fparam_avg is None:
self.fparam_avg = 0.
if self.fparam_inv_std is None:
self.fparam_inv_std = 1.
deepmd/fit/ener.py
Outdated
Comment on lines
+385
to
+386
| self.aparam_avg = 0. | ||
| self.aparam_inv_std = 1. |
Collaborator
There was a problem hiding this comment.
The same suggestion for aparam
Codecov Report
@@ Coverage Diff @@
## devel #1695 +/- ##
==========================================
- Coverage 76.07% 76.03% -0.04%
==========================================
Files 94 94
Lines 7863 7875 +12
==========================================
+ Hits 5982 5988 +6
- Misses 1881 1887 +6
Continue to review full report at Codecov.
|
mingzhong15
pushed a commit
to mingzhong15/deepmd-kit
that referenced
this pull request
Jan 15, 2023
…ng#1695) * set default fparam and aparam stat and recover from graph fix deepmodeling#1692 * check avg and std separately
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1692