optimize format_nlist_i_cpu#1717
Merged
wanghan-iapcm merged 1 commit intodeepmodeling:develfrom May 18, 2022
Merged
Conversation
1. Compare square value instead of square root value. Square root is expensive. 2. Compare float instead of double, considering rcut is provided as float. `ProdEnvMatA` (CPU) is observed to improve over 5%.
Codecov Report
@@ Coverage Diff @@
## devel #1717 +/- ##
=======================================
Coverage 76.03% 76.03%
=======================================
Files 94 94
Lines 7875 7875
=======================================
Hits 5988 5988
Misses 1887 1887 Continue to review full report at Codecov.
|
amcadmus
approved these changes
May 18, 2022
mingzhong15
pushed a commit
to mingzhong15/deepmd-kit
that referenced
this pull request
Jan 15, 2023
1. Compare square value instead of square root value. Square root is expensive. 2. Compare float instead of double, considering rcut is provided as float. `ProdEnvMatA` (CPU) is observed to improve over 5%.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProdEnvMatA(CPU) is observed to improve over 5%.