Skip to content

replace GPU 1./sqrt with rsqrt #1741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wanghan-iapcm merged 3 commits into from
Jun 7, 2022
Merged

replace GPU 1./sqrt with rsqrt #1741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38e78f8
replace 1./sqrt with rsqrt
njzjz Jun 4, 2022
f23e456
remove FPTYPE as it has been FPTYPE
njzjz Jun 4, 2022
486fb8c
apply the same opt for ROCM
njzjz Jun 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions source/lib/src/cuda/prod_env_mat.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

__device__ inline double _sqrt(double x) {return sqrt(x);}
__device__ inline float _sqrt(float x) {return sqrtf(x);}
__device__ inline double _rsqrt(double x) {return rsqrt(x);}
__device__ inline float _rsqrt(float x) {return rsqrtf(x);}

// common part of prod_env_mat
template <
Expand Down Expand Up @@ -408,7 +410,7 @@ __global__ void compute_env_mat_a(
}
// const FPTYPE * rr = &row_rij[ii * 3];
FPTYPE nr2 = dev_dot(rr, rr);
FPTYPE inr = (FPTYPE)1./_sqrt(nr2);
FPTYPE inr = _rsqrt(nr2);
FPTYPE nr = nr2 * inr;
FPTYPE inr2 = inr * inr;
FPTYPE inr4 = inr2 * inr2;
Expand Down Expand Up @@ -494,7 +496,7 @@ __global__ void compute_env_mat_r(
}
// const FPTYPE * rr = &row_rij[ii * 3];
FPTYPE nr2 = dev_dot(rr, rr);
FPTYPE inr = (FPTYPE)1./_sqrt(nr2);
FPTYPE inr = _rsqrt(nr2);
FPTYPE nr = nr2 * inr;
FPTYPE inr2 = inr * inr;
FPTYPE inr4 = inr2 * inr2;
Expand Down
6 changes: 4 additions & 2 deletions source/lib/src/rocm/prod_env_mat.hip.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@

__device__ inline double _sqrt(double x) {return sqrt(x);}
__device__ inline float _sqrt(float x) {return sqrtf(x);}
__device__ inline double _rsqrt(double x) {return rsqrt(x);}
__device__ inline float _rsqrt(float x) {return rsqrtf(x);}

// common part of prod_env_mat
template <
Expand Down Expand Up @@ -406,7 +408,7 @@ __global__ void compute_env_mat_a(
}
// const FPTYPE * rr = &row_rij[ii * 3];
FPTYPE nr2 = dev_dot(rr, rr);
FPTYPE inr = (FPTYPE)1./_sqrt(nr2);
FPTYPE inr = _rsqrt(nr2);
FPTYPE nr = nr2 * inr;
FPTYPE inr2 = inr * inr;
FPTYPE inr4 = inr2 * inr2;
Expand Down Expand Up @@ -492,7 +494,7 @@ __global__ void compute_env_mat_r(
}
// const FPTYPE * rr = &row_rij[ii * 3];
FPTYPE nr2 = dev_dot(rr, rr);
FPTYPE inr = (FPTYPE)1./_sqrt(nr2);
FPTYPE inr = _rsqrt(nr2);
FPTYPE nr = nr2 * inr;
FPTYPE inr2 = inr * inr;
FPTYPE inr4 = inr2 * inr2;
Expand Down