Skip to content

remove white space from train_attr/training_script#1870

Merged
wanghan-iapcm merged 1 commit intodeepmodeling:develfrom
njzjz:remove_white_space
Aug 24, 2022
Merged

remove white space from train_attr/training_script#1870
wanghan-iapcm merged 1 commit intodeepmodeling:develfrom
njzjz:remove_white_space

Conversation

@njzjz
Copy link
Member

@njzjz njzjz commented Aug 21, 2022

#921 discussed that the tensors are compressed in the graph file. But it looks no... So at least we remove white space.

When any graph file is opened, it is clear that train_attr/training_script is stored as raw text.
image

deepmodeling#921 discussed that the tensors are compressed in the graph file. But it looks no... So at least we remove white space.
@njzjz njzjz requested a review from denghuilu August 21, 2022 18:42
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2022

Codecov Report

Merging #1870 (5bdffcb) into devel (0585520) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##            devel    #1870   +/-   ##
=======================================
  Coverage   76.98%   76.98%           
=======================================
  Files         117      117           
  Lines        9417     9417           
=======================================
  Hits         7250     7250           
  Misses       2167     2167           
Impacted Files Coverage Δ
deepmd/entrypoints/train.py 87.79% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@denghuilu denghuilu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@njzjz njzjz requested a review from wanghan-iapcm August 23, 2022 03:14
@wanghan-iapcm wanghan-iapcm merged commit 5d26f17 into deepmodeling:devel Aug 24, 2022
@njzjz njzjz deleted the remove_white_space branch August 24, 2022 02:08
mingzhong15 pushed a commit to mingzhong15/deepmd-kit that referenced this pull request Jan 15, 2023
deepmodeling#921 discussed that the tensors are compressed in the graph file. But it looks no... So at least we remove white space.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants