Skip to content

use float/double constants for spline5_switch#1985

Merged
wanghan-iapcm merged 2 commits intodeepmodeling:develfrom
njzjz:float-spline5_switch
Oct 12, 2022
Merged

use float/double constants for spline5_switch#1985
wanghan-iapcm merged 2 commits intodeepmodeling:develfrom
njzjz:float-spline5_switch

Conversation

@njzjz
Copy link
Member

@njzjz njzjz commented Oct 11, 2022

Same as #1647, but a function was missing.

Same as deepmodeling#1647, but a function was missing.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@github-actions github-actions bot added the Core label Oct 11, 2022
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@codecov-commenter
Copy link

Codecov Report

Base: 73.56% // Head: 42.16% // Decreases project coverage by -31.39% ⚠️

Coverage data is based on head (104b14a) compared to base (f5289c9).
Patch coverage: 71.42% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##            devel    #1985       +/-   ##
===========================================
- Coverage   73.56%   42.16%   -31.40%     
===========================================
  Files         198       66      -132     
  Lines       19916     6526    -13390     
  Branches      854        0      -854     
===========================================
- Hits        14651     2752    -11899     
+ Misses       4877     3774     -1103     
+ Partials      388        0      -388     
Impacted Files Coverage Δ
source/lib/include/switcher.h 81.81% <71.42%> (ø)
source/op/soft_min_virial.cc 3.84% <0.00%> (-90.60%) ⬇️
source/op/soft_min_force.cc 5.00% <0.00%> (-87.86%) ⬇️
source/op/soft_min.cc 3.07% <0.00%> (-87.84%) ⬇️
source/op/pair_tab.cc 2.10% <0.00%> (-87.07%) ⬇️
source/op/ewald_recp.cc 2.77% <0.00%> (-86.51%) ⬇️
source/op/prod_env_mat_multi_device_nvnmd.cc 1.05% <0.00%> (-83.85%) ⬇️
source/op/prod_force.cc 3.77% <0.00%> (-78.14%) ⬇️
source/op/unaggregated_grad.cc 1.19% <0.00%> (-77.11%) ⬇️
source/op/neighbor_stat.cc 1.98% <0.00%> (-76.84%) ⬇️
... and 173 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wanghan-iapcm wanghan-iapcm merged commit 77c7ad4 into deepmodeling:devel Oct 12, 2022
mingzhong15 pushed a commit to mingzhong15/deepmd-kit that referenced this pull request Jan 15, 2023
Same as deepmodeling#1647, but a function was missing.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants